[ENG-2914] feat(salesforce): Batch Unit Tests - #2255
Merged
Conversation
This was referenced Nov 3, 2025
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Nov 3, 2025
Cobalt0s
force-pushed
the
cobalt0s/batch-salesforce-write-update
branch
from
November 3, 2025 22:25
d9a5e07 to
c1ec2b4
Compare
Cobalt0s
force-pushed
the
cobalt0s/batch-salesforce-batch-unit-tests
branch
from
November 3, 2025 22:25
24dd75f to
90d2d19
Compare
Cobalt0s
force-pushed
the
cobalt0s/batch-salesforce-batch-unit-tests
branch
from
November 4, 2025 22:57
90d2d19 to
b7d63a9
Compare
Cobalt0s
force-pushed
the
cobalt0s/batch-salesforce-write-update
branch
from
November 4, 2025 22:57
c1ec2b4 to
27d2659
Compare
Cobalt0s
force-pushed
the
cobalt0s/batch-salesforce-batch-unit-tests
branch
from
November 5, 2025 00:51
b7d63a9 to
85830b9
Compare
Cobalt0s
force-pushed
the
cobalt0s/batch-salesforce-write-update
branch
2 times, most recently
from
November 5, 2025 01:06
6f3df60 to
39b8eca
Compare
Cobalt0s
force-pushed
the
cobalt0s/batch-salesforce-batch-unit-tests
branch
from
November 5, 2025 01:06
85830b9 to
d5c1ba1
Compare
Base automatically changed from
cobalt0s/batch-salesforce-write-update
to
main
November 5, 2025 01:10
Cobalt0s
force-pushed
the
cobalt0s/batch-salesforce-batch-unit-tests
branch
from
November 7, 2025 21:21
d5c1ba1 to
1e6cacf
Compare
Cobalt0s
changed the base branch from
graphite-base/2255
to
cobalt0s/unit-tests-batch-write
November 7, 2025 21:21
This was referenced Nov 7, 2025
anushat05
approved these changes
Nov 11, 2025
anushat05
left a comment
anushat05
left a comment
Contributor
There was a problem hiding this comment.
Looks like the build failed. Good to merge after we fix this.
Cobalt0s
changed the base branch from
cobalt0s/unit-tests-batch-write
to
graphite-base/2255
November 11, 2025 20:25
Cobalt0s
force-pushed
the
graphite-base/2255
branch
from
November 11, 2025 23:46
91fea91 to
2f9fa46
Compare
Cobalt0s
force-pushed
the
cobalt0s/batch-salesforce-batch-unit-tests
branch
from
November 11, 2025 23:46
9afdc77 to
131a878
Compare
Cobalt0s
commented
Nov 12, 2025
Cobalt0s
left a comment
Cobalt0s
left a comment
Contributor
Author
There was a problem hiding this comment.
@anushat05
PR is primarily about unit tests.
Some minor Salesforce changes include:
- Include counrers where they were previously forgotten.
- Rare edge case of error format is interpreted to surface the problem instead of returning empty WriteResult.
anushat05
approved these changes
Nov 17, 2025
Cobalt0s
force-pushed
the
cobalt0s/batch-salesforce-batch-unit-tests
branch
from
November 19, 2025 20:09
131a878 to
3b80a6b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description.
Existing behaviour of salesforce is documented with unit tests.