Skip to content

[ENG-2914] feat(interface): BatchWriteConnector#2231

Merged
Cobalt0s merged 5 commits into
mainfrom
cobalt0s/batch-connector
Oct 29, 2025
Merged

[ENG-2914] feat(interface): BatchWriteConnector#2231
Cobalt0s merged 5 commits into
mainfrom
cobalt0s/batch-connector

Conversation

@Cobalt0s
Copy link
Copy Markdown
Contributor

@Cobalt0s Cobalt0s commented Oct 29, 2025

Description

Added interface and included types generated from amp-labs/openapi#240

Copy link
Copy Markdown
Contributor Author

Cobalt0s commented Oct 29, 2025

@Cobalt0s Cobalt0s self-assigned this Oct 29, 2025
@Cobalt0s Cobalt0s marked this pull request as ready for review October 29, 2025 18:54
Comment thread common/types.go Outdated
Comment thread common/types.go
Comment thread connectors.go Outdated
@Cobalt0s Cobalt0s force-pushed the cobalt0s/batch-connector branch from 29614cf to 894b192 Compare October 29, 2025 19:35
@Cobalt0s Cobalt0s enabled auto-merge (squash) October 29, 2025 19:43
@Cobalt0s Cobalt0s force-pushed the cobalt0s/batch-connector branch from f41c9a6 to 6ca9007 Compare October 29, 2025 19:56
Copy link
Copy Markdown
Contributor

@laurenzlong laurenzlong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please don't forget to re-generate the types after you update amp-labs/openapi#240

Comment thread common/types.go Outdated
Comment thread common/types.go Outdated
Comment thread common/types.go
Comment thread common/types.go
Comment thread common/types.go Outdated
Comment thread connectors.go Outdated
Comment thread common/types.go Outdated
@Cobalt0s Cobalt0s force-pushed the cobalt0s/batch-connector branch from 536928f to d749c05 Compare October 29, 2025 22:04
@Cobalt0s Cobalt0s requested a review from laurenzlong October 29, 2025 22:06
@laurenzlong laurenzlong changed the title [ENG-2914] feat(interface): BatchWriterConnector [ENG-2914] feat(interface): BatchWriteConnector Oct 29, 2025
@Cobalt0s Cobalt0s disabled auto-merge October 29, 2025 22:12
@Cobalt0s Cobalt0s enabled auto-merge (squash) October 29, 2025 22:12
Copy link
Copy Markdown
Contributor

@laurenzlong laurenzlong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to re-generate types again

@Cobalt0s Cobalt0s merged commit dcffeb3 into main Oct 29, 2025
6 checks passed
@Cobalt0s Cobalt0s deleted the cobalt0s/batch-connector branch October 29, 2025 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants