Skip to content

[ENG-2914] feat(salesforce): BatchWrite Create#2233

Merged
Cobalt0s merged 4 commits into
mainfrom
cobalt0s/batch-salesforce-write
Nov 5, 2025
Merged

[ENG-2914] feat(salesforce): BatchWrite Create#2233
Cobalt0s merged 4 commits into
mainfrom
cobalt0s/batch-salesforce-write

Conversation

@Cobalt0s
Copy link
Copy Markdown
Contributor

@Cobalt0s Cobalt0s commented Oct 29, 2025

Live Tests

Create contacts:
image

Try creating contacts where first is missing family name:
image

Salesforce batch create uses rule: "all or none". This cannot be controlled.

Why do we see {}?

  • WriteResult.Errors can be either string, struct, error. The print utilities handle display of strings and JSON well, but not golang error. In fact this is common.ErrBatchUnprocessedRecord.

@Cobalt0s Cobalt0s self-assigned this Oct 29, 2025
@Cobalt0s Cobalt0s changed the base branch from cobalt0s/batch-salesforce to graphite-base/2233 October 31, 2025 02:31
@Cobalt0s Cobalt0s force-pushed the cobalt0s/batch-salesforce-write branch from 96fb988 to 997b5ff Compare October 31, 2025 02:31
@Cobalt0s Cobalt0s changed the base branch from graphite-base/2233 to cobalt0s/record-decorator October 31, 2025 02:31
@Cobalt0s Cobalt0s changed the title [ENG-2914] feat(salesforce): Batch Write [ENG-2914] feat(salesforce): BatchWrite Create Oct 31, 2025
@Cobalt0s Cobalt0s marked this pull request as ready for review October 31, 2025 03:29
@Cobalt0s Cobalt0s requested a review from laurenzlong October 31, 2025 03:29
Comment thread providers/salesforce/internal/crm/batch/adapter.go
Comment thread test/salesforce/batch/create/contacts/main.go
@Cobalt0s Cobalt0s force-pushed the cobalt0s/batch-salesforce-write branch from 997b5ff to 7a227bd Compare November 3, 2025 21:57
@Cobalt0s Cobalt0s force-pushed the cobalt0s/record-decorator branch from 94c3e21 to 483ce73 Compare November 3, 2025 21:57
@Cobalt0s Cobalt0s changed the base branch from cobalt0s/record-decorator to graphite-base/2233 November 4, 2025 17:33
@Cobalt0s Cobalt0s requested a review from anushat05 November 4, 2025 22:54
@Cobalt0s Cobalt0s force-pushed the cobalt0s/batch-salesforce-write branch from 7a227bd to 8849f2b Compare November 4, 2025 22:57
@Cobalt0s Cobalt0s changed the base branch from graphite-base/2233 to cobalt0s/record-decorator November 4, 2025 22:57
Copy link
Copy Markdown
Contributor

@anushat05 anushat05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One high-level comment on the bug that we found earlier today - when you pass even a single existing email in combination with non-existing one it panics. Do we wanna address it as a part of this PR?

@Cobalt0s Cobalt0s force-pushed the cobalt0s/batch-salesforce-write branch from 8849f2b to ff70756 Compare November 5, 2025 00:51
@Cobalt0s Cobalt0s force-pushed the cobalt0s/record-decorator branch from deb0891 to a2ad746 Compare November 5, 2025 00:51
Base automatically changed from cobalt0s/record-decorator to main November 5, 2025 00:57
@Cobalt0s
Copy link
Copy Markdown
Contributor Author

Cobalt0s commented Nov 5, 2025

One high-level comment on the bug that we found earlier today - when you pass even a single existing email in combination with non-existing one it panics. Do we wanna address it as a part of this PR?

I am not able to replicate this issue. Lets merge this PR and if the problem is discovered during integration testing we can do PR to fix it.

@Cobalt0s Cobalt0s merged commit e0c4783 into main Nov 5, 2025
9 checks passed
@Cobalt0s Cobalt0s deleted the cobalt0s/batch-salesforce-write branch November 5, 2025 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants