[ENG-2914] feat(salesforce): BatchWrite Create#2233
Merged
Conversation
Contributor
Author
96fb988 to
997b5ff
Compare
9cd9548 to
94c3e21
Compare
This was referenced Oct 31, 2025
anushat05
reviewed
Oct 31, 2025
997b5ff to
7a227bd
Compare
94c3e21 to
483ce73
Compare
483ce73 to
deb0891
Compare
7a227bd to
8849f2b
Compare
anushat05
reviewed
Nov 4, 2025
Contributor
anushat05
left a comment
There was a problem hiding this comment.
One high-level comment on the bug that we found earlier today - when you pass even a single existing email in combination with non-existing one it panics. Do we wanna address it as a part of this PR?
8849f2b to
ff70756
Compare
deb0891 to
a2ad746
Compare
Contributor
Author
I am not able to replicate this issue. Lets merge this PR and if the problem is discovered during integration testing we can do PR to fix it. |
anushat05
approved these changes
Nov 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Live Tests
Create contacts:

Try creating contacts where first is missing family name:

Salesforce batch create uses rule: "all or none". This cannot be controlled.
Why do we see
{}?WriteResult.Errorscan be eitherstring,struct,error. The print utilities handle display of strings and JSON well, but not golangerror. In fact this iscommon.ErrBatchUnprocessedRecord.