Skip to content

[ENG-3905] feat(hubspot): Add Marketing module#2958

Closed
Cobalt0s wants to merge 1 commit into
cobalt0s/hubspot-multi-modulefrom
cobalt0s/hubspot-marketing
Closed

[ENG-3905] feat(hubspot): Add Marketing module#2958
Cobalt0s wants to merge 1 commit into
cobalt0s/hubspot-multi-modulefrom
cobalt0s/hubspot-marketing

Conversation

@Cobalt0s
Copy link
Copy Markdown
Contributor

@Cobalt0s Cobalt0s commented May 6, 2026

Description

Introduces the Marketing module to the HubSpot connector.

At this stage, the Marketing module establishes the connector structure and routing needed to support Marketing APIs, while most implementation details remain shared with the existing CRM module.

Changes

  • Extended ProviderInfo with a new HubSpot Marketing module definition.
  • Moved and renamed internal/crm/core to internal/shared.
    • For now, the separation between CRM and Marketing is mostly structural.
    • API versioning, read output parsing, and error handling remain identical, so these utilities are now shared across HubSpot modules.
  • Added a placeholder adapter in internal/marketing/adapter.go.
    • The adapter implements ListObjectMetadata, Read, Write, and Delete.
    • All methods currently return common.ErrNotImplemented.
  • The HubSpot connector now initializes the Marketing adapter when the selected module is Marketing.
  • Updated all public connector methods to route requests to the initialized adapter.
    • Connector methods now support routing to either the CRM or Marketing adapter.
  • Updated live test helpers:
    • GetHubspotConnector was renamed to GetHubspotCRMConnector.
    • Added a new GetHubspotMarketingConnector constructor for Marketing module tests.

@linear
Copy link
Copy Markdown

linear Bot commented May 6, 2026

Copy link
Copy Markdown
Contributor Author

Cobalt0s commented May 6, 2026

@Cobalt0s Cobalt0s force-pushed the cobalt0s/hubspot-marketing branch from 6a27138 to d1589e1 Compare May 6, 2026 18:22
@Cobalt0s Cobalt0s force-pushed the cobalt0s/hubspot-multi-module branch from 5aa5cca to 9235eee Compare May 6, 2026 18:22
@Cobalt0s Cobalt0s self-assigned this May 6, 2026
@Cobalt0s Cobalt0s marked this pull request as ready for review May 6, 2026 18:41
@Cobalt0s Cobalt0s requested a review from laurenzlong May 6, 2026 19:13
@Cobalt0s
Copy link
Copy Markdown
Contributor Author

Cobalt0s commented May 7, 2026

Hubspot won't be using modules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant