Generic javascript template support [WIP] #8
Conversation
…docker script for running tests and modified entrypoint to take argument "test"
…p template with react imports. Will work on adding new general dashboard now
…mo, will restore afterwards"
… when ampcrowd doesn't really use numpy except for some random number skewing.
|
We have a Jenkins setup in place at the lab. I'll look in to getting this project running on it. |
| @@ -28,6 +28,13 @@ def __unicode__(self): | |||
| class Meta: | |||
| abstract = True | |||
|
|
|||
| @staticmethod | |||
| def to_json(task_group): | |||
There was a problem hiding this comment.
these methods aren't actually outputting JSON. Either have the method return json.dumps(return_dict), or rename it to_dict().
There was a problem hiding this comment.
Good catch, the json_view decorator can automatically convert the dict so will do to_dict
|
Can one of the admins verify this patch? |
|
ok to test |
|
Test FAILed. |
|
test this please |
|
Test PASSed. |
First, this is a WIP, but want to get feedback early on the overall design/implementation. Eventually I hope to get everything implemented that is in #7.
Initially, I have added the django models, tests to make sure they work correctly, and a test script with modifications to the docker entrypoint to run these tests. Tests pass at the moment.
I will make an issue, but I think since we now are adding tests, we should have tests being run on at least PRs. Travis CI would be nice, but I don't think would play with docker, so that leaves Jenkins. At Trulia I have a Jenkins server setup that builds with docker, I could set something similar up if there was a machine I could use (perhaps from AMPLab?).