ADA4355 HDL updates #1761
Open
ADA4355 HDL updates #1761
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PIoandan
force-pushed
the
ada4355_xdc_update
branch
2 times, most recently
from
a75a5de to
314b08a
Compare
Signed-off-by: Pop Ioan Daniel <[email protected]>
PIoandan
force-pushed
the
ada4355_xdc_update
branch
from
f5eab0f to
7bb469d
Compare
PIoandan
requested review from
IuliaCMoldovan,
gastmaier,
StancaPop,
LBFFilho and
PIoandan
as code owners
IuliaCMoldovan
requested changes
Jul 14, 2025
Comment on lines
+79
to
+94
| By default it is set to 0. Depending on the type of evaluation board, some | ||
| hardware modifications need to be done on the board and/or ``make`` command: | ||
|
|
||
| In case of the Eval-Board with optimized xdc: | ||
|
|
||
| .. shell:: bash | ||
|
|
||
| $make BUFMRCE_EN=0 | ||
|
|
||
| In case of the Eval-Board with non optimized xdc: | ||
|
|
||
| .. shell:: bash | ||
|
|
||
| $make BUFMRCE_EN=1 | ||
|
|
||
|
|
There was a problem hiding this comment.
Could you give some details on how to differentiate these boards? Are they named with rev. A/B? If not, are there any distinctive marks on the evaluation board?
Suggested change
| By default it is set to 0. Depending on the type of evaluation board, some | |
| hardware modifications need to be done on the board and/or ``make`` command: | |
| In case of the Eval-Board with optimized xdc: | |
| .. shell:: bash | |
| $make BUFMRCE_EN=0 | |
| In case of the Eval-Board with non optimized xdc: | |
| .. shell:: bash | |
| $make BUFMRCE_EN=1 | |
| By default, BUFMRCE_EN is set to 0. Depending on the type of evaluation board, some | |
| hardware changes need to be done on it and/or for the `make` command: | |
| In case of the newer version of the board (with optimized constraints): | |
| .. shell:: bash | |
| ~/hdl/projects/ada3455_fmc/zed | |
| $make BUFMRCE_EN=0 | |
| In case of the older version of the board (with non-optimized constraints): | |
| .. shell:: bash | |
| ~/hdl/projects/ada3455_fmc/zed | |
| $make BUFMRCE_EN=1 | |
projects/ada4355_fmc/zed/README.md
Outdated
| @@ -1,8 +1,38 @@ | |||
| # ADA4355 Zed HDL Project | |||
| <!-- no_build_example, no_dts, no_no_os --> | |||
There was a problem hiding this comment.
Suggested change
| <!-- no_build_example, no_dts, no_no_os --> | |
| <!-- no_dts, no_no_os --> |
| ``` | ||
|
|
||
| This project supports two evaluation boards, which are differentiated by how the frame clock signals are distributed. |
There was a problem hiding this comment.
Please write here the distinctive marks, so the users know which is an older board and which is a newer board.
projects/ada4355_fmc/zed/README.md
Outdated
Comment on lines
21
to
23
| - 0 - Eval-Board with optimized xdc | ||
| - 1 - Eval-Board with non optimized xdc |
There was a problem hiding this comment.
Suggested change
| - BUFMRCE_EN - Specifies the eval-board type | |
| - 0 - Eval-Board with optimized xdc | |
| - 1 - Eval-Board with non optimized xdc | |
| - BUFMRCE_EN - Specifies the evaluation board type | |
| - 0 - newer evaluation board, with optimized constraints (default) | |
| - 1 - older evaluation board, with non-optimized constraints |
projects/ada4355_fmc/zed/README.md
Outdated
Comment on lines
33
to
35
| #### BUFMRCE_EN enabled |
There was a problem hiding this comment.
Add an empty line before line 34
projects/ada4355_fmc/zed/Makefile
Outdated
| ## Copyright (c) 2018 - 2025 Analog Devices, Inc. | ||
| ## Copyright (c) 2025 Analog Devices, Inc. |
There was a problem hiding this comment.
This can be reverted
docs/projects/ada4355_fmc/index.rst
Outdated
Comment on lines
196
to
275
| $make | ||
| $make BUFMRCE_EN=0 |
There was a problem hiding this comment.
Revert this, and write below "Example for how to..." like it is done for other projects
Update xdc constraints Loop back TRIG SMAs Add BUFMRCE_EN parameter Signed-off-by: Pop Ioan Daniel <[email protected]>
Signed-off-by: Pop Ioan Daniel <[email protected]>
PIoandan
force-pushed
the
ada4355_xdc_update
branch
from
8879176 to
0046008
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Update HDL project according to the new ada4355 board.
PR Type
PR Checklist