Add support for MAX17616 #2734

cjones-adi · 2025-09-25T04:13:33Z

Pull Request Description

The MAX17616/MAX17616A offers highly versatile and programmable protection boundaries for systems against input voltage faults and output overcurrent faults. Input-voltage faults (with positive polarity) are protected up to +80V (without Reverse Current Protection)/+75V (with Reverse Current Protection), by an internal nFET featuring low ON-resistance (20mΩ typ). The devices feature a programmable undervoltage-lockout (UVLO) thresholds by using external voltage- dividers. The MAX17616 features a programmable overvoltage-lockout (OVLO) while MAX17616A offers a programmable output voltage clamp function through the OVFB pin that features an output voltage limiting regulation during input transient surge events. Input undervoltage and overvoltage protection (MAX17616)/output voltage clamp function (MAX17616A) can be programmed across the entire 3V to 80V operating range.

PR Type

Bug fix (change that fixes an issue)
New feature (change that adds new functionality)
Breaking change (has dependencies in other repos or will cause CI to fail)

PR Checklist

I have followed the Coding style guidelines
I have complied with the Submission Checklist
I have performed a self-review of the changes
I have commented my code, at least hard-to-understand parts
I have build all projects affected by the changes in this PR
I have tested in hardware affected projects, at the relevant boards
I have signed off all commits from this PR
I have updated the documentation (wiki pages, ReadMe etc), if applies

CLAassistant · 2025-09-25T04:13:40Z

All committers have signed the CLA.

buha · 2025-09-29T12:44:11Z

/AzurePipelines run

azure-pipelines · 2025-09-29T12:44:23Z

Azure Pipelines successfully started running 2 pipeline(s).

kister-jimenez · 2025-09-30T01:29:40Z

/AzurePipelines run

azure-pipelines · 2025-09-30T01:29:53Z

Azure Pipelines successfully started running 2 pipeline(s).

cjones-adi · 2025-09-30T04:26:44Z

V2:

Rebase to latest main
Move max17616.rst to respective doc/sphinx/source directory
Fix astyle errors on identified files

kister-jimenez · 2025-09-30T06:59:29Z

/AzurePipelines run

azure-pipelines · 2025-09-30T06:59:41Z

Azure Pipelines successfully started running 2 pipeline(s).

cjones-adi · 2025-10-01T02:34:19Z

V3:

Resolve identified Sphinx documentation errors

jemfgeronimo · 2025-10-01T02:45:35Z

/AzurePipelines run

azure-pipelines · 2025-10-01T02:45:47Z

Azure Pipelines successfully started running 2 pipeline(s).

cjones-adi · 2025-10-01T04:12:19Z

V4:

Remove diff headers included in max17616.h

cjones-adi · 2025-10-01T22:47:48Z

/AzurePipelines run

azure-pipelines · 2025-10-01T22:47:54Z

Commenter does not have sufficient privileges for PR 2734 in repo analogdevicesinc/no-OS

kister-jimenez · 2025-10-02T02:17:07Z

/AzurePipelines run

azure-pipelines · 2025-10-02T02:17:21Z

Azure Pipelines successfully started running 2 pipeline(s).

kseerp

Hi, minor comments on my end.

kseerp · 2025-10-28T07:34:16Z

drivers/power/max17616/max17616.c

+		if (ret == 0)
+			*value = max17616_direct_to_int(raw_value,
+							&max17616_vin_coeffs);


error handling be done first, and only do the value conversion if the read was successful

ret = max17616_read_word(dev, MAX17616_CMD(MAX17616_READ_VIN), &raw_value); if (ret) return ret; *value = max17616_direct_to_int(raw_value, &max17616_vin_coeffs);

Thanks. Fixed in latest commit.

kseerp · 2025-10-28T07:37:26Z

drivers/power/max17616/max17616.c

+	case MAX17616_POWER:
+		/* Calculate power from voltage and current */
+	{
+		int vin, iout;


variable declarations should be moved to top of function

Thanks. Fixed in latest commit.

kseerp · 2025-10-28T07:37:34Z

drivers/power/max17616/max17616.c

+		if (ret == 0)
+			*value = vin * iout;


error handling be done first before processing success case

Thanks. Fixed in latest commit.

kseerp · 2025-10-28T07:38:04Z

drivers/power/max17616/max17616.c

+	int ret = max17616_read_byte(dev,MAX17616_CMD(MAX17616_OPERATION),
+				   &operation);
+
+	if (ret == 0)
+		*enabled = (operation & 0x80) ? true : false;


Thanks. Fixed in latest commit.

kseerp · 2025-10-28T07:38:08Z

drivers/power/max17616/max17616.c

+
+	/* Extract bits 7:6 and convert to enum */
+	switch (raw_value & 0xC0) {
+	case 0x00:


consider using macros in switch cases

Thanks. Fixed in latest commit.

kseerp · 2025-10-28T07:38:15Z

drivers/power/max17616/max17616.c

+
+	/* Extract bits 3:0 and convert to enum */
+	switch (raw_value & 0x0F) {
+	case 0x00:


Thanks. Fixed in latest commit.

kseerp · 2025-10-28T07:39:08Z

drivers/power/max17616/max17616.h

+	MAX17616_STATUS_BIT_GENERAL	= 0,	// Not supported
+	MAX17616_STATUS_BIT_CML		= 1,	// Comms, memory, or logic Fault
+	MAX17616_STATUS_BIT_TEMPERATURE	= 2,	// Temperature Fault or Warning
+	MAX17616_STATUS_BIT_VIN_UV	= 3,	// Input Under Voltage Fault
+	MAX17616_STATUS_BIT_IOUT_OC	= 4,	// Output Over Current Fault
+	MAX17616_STATUS_BIT_VOUT_OV	= 5,	// An output overvoltage fault occurred
+	MAX17616_STATUS_BIT_OFF		= 6,	// Max17616 is not enabled
+	MAX17616_STATUS_BIT_BUSY	= 7	// Not supported


no need for explicit numbering since enum values are already in correct order

Thanks. Fixed in latest commit.

kseerp · 2025-10-28T07:39:13Z

drivers/power/max17616/max17616.h

+	MAX17616_STATUS_BIT_STARTUP	= 0,	// Not supported
+	MAX17616_STATUS_BIT_OTHER	= 1,	// Not supported
+	MAX17616_STATUS_BIT_FANS	= 2,	// Not supported
+	MAX17616_STATUS_BIT_POWER_GOOD	= 3,	// Not supported
+	MAX17616_STATUS_BIT_MFR		= 4,	// Manufacturer specific Fault
+	MAX17616_STATUS_BIT_INPUT	= 5,	// Input V, I, or P Fault
+	MAX17616_STATUS_BIT_IOUT_POUT	= 6,	// Output current or power Fault
+	MAX17616_STATUS_BIT_VOUT	= 7	// Output voltage Fault


Thanks. Fixed in latest commit.

jemfgeronimo

Some minor changes. Also, use the new example infrastructure like I mentioned here.

jemfgeronimo · 2025-10-29T02:30:58Z

drivers/power/max17616/max17616.c

+	/* Step 1: Verify manufacturer ID */
+	ret = max17616_verify_manufacturer_id(dev);
+	if (ret)
+		return ret;
+
+	/* Step 2: Identify chip variant */
+	ret = max17616_identify_chip_variant(dev);
+	if (ret)
+		return ret;
+
+	/* Step 3: Verify PMBus revision */
+	ret = max17616_verify_pmbus_revision(dev);


Comments seem redundant since the function names are self-explanatory.

Thanks. Fixed in latest commit.

jemfgeronimo · 2025-10-29T02:46:25Z

drivers/power/max17616/max17616.c

+	/* Initialize telemetry structure */
+	memset(telemetry, 0, sizeof(struct max17616_telemetry));
+
+	/* Read VIN using DIRECT format */
+	ret = max17616_read_value(dev, MAX17616_VIN, &telemetry->vin);
+	if (ret == 0)
+		telemetry->valid_mask |= NO_OS_BIT(0);
+
+	/* Read VOUT using DIRECT format */
+	ret = max17616_read_value(dev, MAX17616_VOUT, &telemetry->vout);
+	if (ret == 0)
+		telemetry->valid_mask |= NO_OS_BIT(1);
+
+	/* Read IOUT using DIRECT format */
+	ret = max17616_read_value(dev, MAX17616_IOUT, &telemetry->iout);
+	if (ret == 0)
+		telemetry->valid_mask |= NO_OS_BIT(3);
+
+	/* Read Temperature using DIRECT format */
+	ret = max17616_read_value(dev, MAX17616_TEMP, &telemetry->temp1);


Comments are redundant; the function calls already describe what’s happening.

Thanks. Fixed in latest commit.

jemfgeronimo · 2025-10-29T02:49:09Z

drivers/power/max17616/max17616.c


-	int ret = max17616_read_byte(dev,MAX17616_CMD(MAX17616_OPERATION),
-				   &operation);
+	int ret = max17616_read_byte(dev, MAX17616_CMD(MAX17616_OPERATION),


Include max17616.c and max17616.h changes to the previous commit.

Thanks. Fixed in latest commit.

jemfgeronimo · 2025-10-29T02:52:10Z

drivers/power/max17616/iio_max17616.c

+	int value;
+	int ret;
+
+	/* Parse the input value */


Unnecessary comment.

Thanks. Fixed in latest commit.

jemfgeronimo · 2025-10-29T02:56:54Z

drivers/power/max17616/iio_max17616.c

+	case 0: { /* operation */
+		bool enabled;
+		ret = max17616_get_operation_state(iio_max17616->max17616_dev, &enabled);
+		if (ret)
+			return ret;
+		return snprintf(buf, len, "%s", enabled ? "enabled" : "disabled");
+	}
+
+	case 2: /* device_info */
+		return snprintf(buf, len, "MAX17616/MAX17616A Protection IC");
+
+	case 3: { /* fault_summary */
+		struct max17616_status status;
+		ret = max17616_read_status(iio_max17616->max17616_dev, &status);
+		if (ret)
+			return ret;
+
+		if (status.word == 0) {
+			return snprintf(buf, len, "No faults");
+		}
+
+		char fault_info[256] = {0};
+		int pos = 0;
+
+		if (status.vout) pos += snprintf(fault_info + pos, sizeof(fault_info) - pos,
+							 "VOUT_FAULT ");
+		if (status.iout) pos += snprintf(fault_info + pos, sizeof(fault_info) - pos,
+							 "IOUT_FAULT ");
+		if (status.input) pos += snprintf(fault_info + pos, sizeof(fault_info) - pos,
+							  "VIN_FAULT ");
+		if (status.temperature) pos += snprintf(fault_info + pos,
+								sizeof(fault_info) - pos, "TEMP_FAULT ");
+		if (status.cml) pos += snprintf(fault_info + pos, sizeof(fault_info) - pos,
+							"CML_FAULT ");
+		if (status.mfr_specific) pos += snprintf(fault_info + pos,
+							sizeof(fault_info) - pos, "MFR_FAULT ");
+
+		return snprintf(buf, len, "%s", fault_info);
+	}
+	case 4: { /* capability */


Avoid magic numbers. Replace them with enum values for case labels.

Thanks. Fixed in latest commit.

jemfgeronimo · 2025-10-29T02:57:19Z

drivers/power/max17616/iio_max17616.c

+	case 0: { /* operation */
+		int enable = 0;
+		if (!strncmp(buf, "1", 1) || !strncasecmp(buf, "enable", 6)) {
+			enable = 1;
+		}
+		return max17616_set_operation_state(iio_max17616->max17616_dev, enable);
+	}
+
+	case 1: /* clear_faults */


Ditto: magic numbers

Thanks. Fixed in latest commit.

cjones-adi · 2025-10-31T11:04:35Z

V5:

Improve error handling on max17616.c.
Move variable declaration to top of function.
Use macros in switch cases.
Remove explicit value assignments in enum declarations.
Change to new example infrastructure.
Remove redundant comments on self-explanatory function names.
Remove magic numbers by adding descriptive macros.
Fix file content in commit.

kister-jimenez · 2025-10-31T11:18:21Z

/AzurePipelines run

azure-pipelines · 2025-10-31T11:18:33Z

Azure Pipelines successfully started running 2 pipeline(s).

cjones-adi · 2025-10-31T14:39:11Z

V6:

Fix error in builds.json (was iio instead of iio_example)

jemfgeronimo · 2025-11-02T23:40:42Z

drivers/power/max17616/max17616.c

+	struct max17616_dev *dev;
+	int ret = -EINVAL;
+
+	dev = (struct max17616_dev *)no_os_calloc(0, sizeof(struct max17616_dev));


Typo?

Suggested change

dev = (struct max17616_dev *)no_os_calloc(0, sizeof(struct max17616_dev));

dev = (struct max17616_dev *)no_os_calloc(1, sizeof(struct max17616_dev));

Great catch! Thanks!

Thanks. Fixed in latest commit.

jemfgeronimo · 2025-11-03T00:11:50Z

drivers/power/max17616/iio_max17616.c

+	{
+		.name = "raw",
+		.show = max17616_iio_read_attr,
+	},
+	{
+		.name = "scale",
+		.show = max17616_iio_read_attr,
+	},


I'm seeing the same max17616_iio_read_attr function used to access both raw and scale, yet no priv to differentiate between them. Typically, raw represents the unscaled register value, while scale provides the conversion factor used to compute the physical quantity (raw * scale + offset). If I understand correctly, in this case, reading the raw and scale attributes would both return the same raw data.

Yes, it returns the same data. For this case, with specs to use DIRECT method of transforming data, returned values are in V, I, or degC units already (similar cases are devices LTC4162L and LT8491 where the read values are in engineering units already and the scale factor used is 1). I'll use the .priv field and scale factor 1 for IIO compliance.

Thanks. Addressed in latest commit.

jemfgeronimo · 2025-11-03T00:21:43Z

drivers/power/max17616/README.rst

+	};
+
+	struct max17616_init_param max17616_ip = {
+		.i2c_init = &_i2c_ip,


Suggested change

.i2c_init = &_i2c_ip,

.i2c_init = &i2c_ip,

Thanks. Fixed in latest commit.

jemfgeronimo · 2025-11-03T00:29:09Z

projects/max17616/src/platform/maxim/platform_src.mk

+INCS += \
+        $(PLATFORM_DRIVERS)/maxim_gpio.h      \
+	$(PLATFORM_DRIVERS)/maxim_gpio_irq.h  \
+	$(PLATFORM_DRIVERS)/maxim_irq.h       \
+        $(PLATFORM_DRIVERS)/../common/maxim_dma.h       \
+	$(PLATFORM_DRIVERS)/maxim_i2c.h       \
+	$(PLATFORM_DRIVERS)/maxim_uart.h      \
+	$(PLATFORM_DRIVERS)/maxim_uart_stdio.h


Nit: Fix indentions. Use tabs instead of spaces.

Thanks. Fixed in latest commit.

jemfgeronimo · 2025-11-03T00:31:40Z

projects/max17616/README.rst

+
+        # Select the example you want to enable by choosing y for enabling and n for disabling
+        BASIC_EXAMPLE = n
+        IIO__EXAMPLE = y


Suggested change

IIO__EXAMPLE = y

IIO_EXAMPLE = y

Thanks. Fixed in latest commit.

cjones-adi · 2025-11-03T02:32:47Z

V7:

Fix bug in device driver calloc
Use .priv in iio attributes
Fix indentations in build file
Remove extra underscore in docs

jemfgeronimo · 2025-11-03T02:51:23Z

V5:

Improve error handling on max17616.c.

Move variable declaration to top of function.

Use macros in switch cases.

Remove explicit value assignments in enum declarations.

Change to new example infrastructure.

Remove redundant comments on self-explanatory function names.

Remove magic numbers by adding descriptive macros.

Fix file content in commit.

Some of these changes were reverted from the latest push.

Add header and source files for max17616 driver. Signed-off-by: Carlos Jones <[email protected]>

Signed-off-by: Carlos Jones <[email protected]>

Add README.rst documentation file for max17616 alongside other documentation related files. Signed-off-by: Carlos Jones <[email protected]>

Add project files for both basic and IIO examples for max17616. Signed-off-by: Carlos Jones <[email protected]>

Add README.rst documentation file for project alongside other documentation related files. Signed-off-by: Carlos Jones <[email protected]>

Add unit test files for the max17616 driver. Signed-off-by: Carlos Jones <[email protected]>

cjones-adi · 2025-11-03T07:47:19Z

V8:

Replay V5 changes

jemfgeronimo · 2025-11-05T06:59:49Z

LGTM

jemfgeronimo · 2025-11-06T06:03:09Z

/AzurePipelines run

azure-pipelines · 2025-11-06T06:03:22Z

Azure Pipelines successfully started running 2 pipeline(s).

kister-jimenez · 2025-11-07T13:20:56Z

LGTM

cjones-adi requested review from CiprianRegus, amiclaus, buha, danmois, dbogdan and rbolboac as code owners September 25, 2025 04:13

cjones-adi force-pushed the dev/max17616 branch from 5513eaa to 94940e7 Compare September 30, 2025 04:24

cjones-adi force-pushed the dev/max17616 branch from 3988f35 to a021cb3 Compare September 30, 2025 06:51

cjones-adi force-pushed the dev/max17616 branch from a021cb3 to 206c239 Compare October 1, 2025 02:32

cjones-adi force-pushed the dev/max17616 branch from 206c239 to cbda533 Compare October 1, 2025 04:11

cjones-adi force-pushed the dev/max17616 branch 2 times, most recently from b1687b3 to 39f0f5a Compare October 1, 2025 04:43

jemfgeronimo self-requested a review October 27, 2025 08:22

kseerp reviewed Oct 28, 2025

View reviewed changes

jemfgeronimo reviewed Oct 29, 2025

View reviewed changes

cjones-adi force-pushed the dev/max17616 branch from 39f0f5a to d74bdb5 Compare October 31, 2025 11:03

cjones-adi force-pushed the dev/max17616 branch from d74bdb5 to 6c0d961 Compare October 31, 2025 14:37

jemfgeronimo reviewed Nov 3, 2025

View reviewed changes

cjones-adi force-pushed the dev/max17616 branch from 6c0d961 to 696bd2b Compare November 3, 2025 02:29

cjones-adi added 6 commits November 3, 2025 15:43

drivers: power: max17616: Add driver support for max17616

ca460e7

Add header and source files for max17616 driver. Signed-off-by: Carlos Jones <[email protected]>

drivers: power: max17616: Add IIO support for MAX17616

7fc925f

Signed-off-by: Carlos Jones <[email protected]>

drivers: power: max17616: Add README documentation for max17616

cca2f5a

Add README.rst documentation file for max17616 alongside other documentation related files. Signed-off-by: Carlos Jones <[email protected]>

projects: max17616: Add project for max17616

39a32ff

Add project files for both basic and IIO examples for max17616. Signed-off-by: Carlos Jones <[email protected]>

projects: max17616: Add README documentation for project

15b6e23

Add README.rst documentation file for project alongside other documentation related files. Signed-off-by: Carlos Jones <[email protected]>

tests: drivers: power: max17616: Add unit tests for max17616

c418df5

Add unit test files for the max17616 driver. Signed-off-by: Carlos Jones <[email protected]>

cjones-adi force-pushed the dev/max17616 branch from 696bd2b to c418df5 Compare November 3, 2025 07:44

kister-jimenez self-requested a review November 7, 2025 13:19

kister-jimenez approved these changes Nov 7, 2025

View reviewed changes

	dev = (struct max17616_dev *)no_os_calloc(0, sizeof(struct max17616_dev));
	dev = (struct max17616_dev *)no_os_calloc(1, sizeof(struct max17616_dev));

Add support for MAX17616 #2734

Are you sure you want to change the base?

Add support for MAX17616 #2734

Uh oh!

Conversation

cjones-adi commented Sep 25, 2025

Pull Request Description

PR Type

PR Checklist

Uh oh!

CLAassistant commented Sep 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

buha commented Sep 29, 2025

Uh oh!

azure-pipelines bot commented Sep 29, 2025

Uh oh!

kister-jimenez commented Sep 30, 2025

Uh oh!

azure-pipelines bot commented Sep 30, 2025

Uh oh!

cjones-adi commented Sep 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kister-jimenez commented Sep 30, 2025

Uh oh!

azure-pipelines bot commented Sep 30, 2025

Uh oh!

cjones-adi commented Oct 1, 2025

Uh oh!

jemfgeronimo commented Oct 1, 2025

Uh oh!

azure-pipelines bot commented Oct 1, 2025

Uh oh!

cjones-adi commented Oct 1, 2025

Uh oh!

cjones-adi commented Oct 1, 2025

Uh oh!

azure-pipelines bot commented Oct 1, 2025

Uh oh!

kister-jimenez commented Oct 2, 2025

Uh oh!

azure-pipelines bot commented Oct 2, 2025

Uh oh!

kseerp left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jemfgeronimo left a comment

CLAassistant commented Sep 25, 2025 •

edited

Loading

cjones-adi commented Sep 30, 2025 •

edited

Loading