Test with ansible-core 2.19

[mariolenz]

Fixes #680

SUMMARY

I think it's about time to start testing with ansible-core 2.19.

ISSUE TYPE

• Feature Pull Request

COMPONENT NAME

.github/workflows/ansible-integration-tests.yml
.github/workflows/ansible-test.yml

ADDITIONAL INFORMATION

https://forum.ansible.com/t/8609/13

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 30.29%. Comparing base (8863545) to head (e6c78fb).
⚠️ Report is 15 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #695   +/-   ##
=======================================
  Coverage   30.29%   30.29%           
=======================================
  Files         177      177           
  Lines       19772    19772           
  Branches     3253     3253           
=======================================
  Hits         5990     5990           
  Misses      13774    13774           
  Partials        8        8           

Flag	Coverage Δ
sanity	29.58% <ø> (ø)
units	61.51% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[felixfontein]

I'm wondering whether the integration tests actually pass, though, since for some reason they have been skipped by this PR...

[thekad]

I think integration tests are only run on merge https://github.com/ansible-collections/google.cloud/blob/master/.github/workflows/ansible-integration-tests.yml#L3-L6

[stevefulme1]

We will put it in our backlog. Since 2.19 is Technical preview currently its not high on our priority scale. We are workign on fixing issues that have been raised, and adding new modules.

[mariolenz]

@stevefulme1 What do you mean with ansible-core 2.19 being technical preview? It has been released 10 days ago on PyPI. It's the latest stable ansible-core release.

[sivel]

What do you mean with ansible-core 2.19 being technical preview?

ansible-core 2.19 is technical preview for AAP customers. The most recent supported version right now is 2.18 within AAP.

[felixfontein]

@stevefulme1 we did re-add google.cloud to Ansible 12 basically last-minute. Ansible 12 is based on ansible-core 2.19. So please make sure ASAP to put this on a high priority. Thanks.

[mariolenz]

@stevefulme1 There has been a request to cancel the removal from / re-add this collection to the Ansible Community Package. We did, but this means you also have to follow the ACP rules like testing with the latest stable ansible-base/ansible-core branch.

It looks like there's maybe a misunderstanding on your side about AAP and ACP and respective requirements.

[thekad]

I ran the integration tests with 2.19 in my dev environment and it almost worked, there's a few modules that are failing right now with jinja templating errors (4 in my testing, as expected), both sanity and unit tests have passed with the new configuration.
I believe integration tests are run only on merge and they are informative cc @SirGitsalot

[SirGitsalot]

@thekad is correct on the integration tests

The sanity tests have started failing in the nightly job due to a Python version mismatch. I think upgrading the version of the anisble-test-gh-action that we're using will fix that. I'll create a PR.

[felixfontein]

Thanks a lot for getting this merged!

[felixfontein]

(I don't think #680 should be closed though, since it's not "fixed" by this PR.)

[mariolenz]

(I don't think #680 should be closed though, since it's not "fixed" by this PR.)

I'm afraid that's my mistake because I've added Fixes #680. Maybe someone (@samccann?) could reopen it again. It looks like I don't have the permissions to do this.

[felixfontein]

Thanks @sivel for reopening it!