Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utilize uv if available for all python pkg installations #306

Merged
merged 4 commits into from
Apr 7, 2025

Conversation

cidrblock
Copy link
Collaborator

@cidrblock cidrblock commented Apr 4, 2025

  • There were a few instances where python -m pip was still being used rather than uv
  • For the uv check, simply see if it is in the path and therefore will be independent of the python interpreter being used
  • We can specify the destination venv with the --python parameter to the uv install command to direct python package installation into the venv w/o specifying it's python path
  • Log the uv command using the output class rather than the logger such that the user can see it
  • Add bindep as a direct dep since it's required for system package assessment
  • Call builder and bindep using the same python interpreter that spawned the ade process.

This also allows ade to be used as a uv tool, which is probably the best way for it to be treated. Installation instructions to be updated in a future PR.

The total test time decreases from 2:43m to 46.98s with these changes.

@cidrblock cidrblock requested a review from a team as a code owner April 4, 2025 22:28
@github-actions github-actions bot added bug Something isn't working dependencies labels Apr 4, 2025
@cidrblock cidrblock requested a review from ssbarnea April 4, 2025 22:29
@cidrblock cidrblock changed the title Utilize uv if available Utilize uv if available for all python pkg installations Apr 4, 2025
@ssbarnea ssbarnea merged commit 2e89cdd into ansible:main Apr 7, 2025
1 check was pending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants