-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Benchmark tests #55
base: main
Are you sure you want to change the base?
Benchmark tests #55
Conversation
Output from github checks as of this last push:
|
I added |
fb3101e
to
3fc3292
Compare
3fc3292
to
f6b5c0c
Compare
Part of the reason I would like to get this in is that #9 will probably share a version of the subprocess fixture for an on-demand dispatcher service for a test. Then that would make a ton of sense for the dab_task app. But I hesitate to look into that as long as this stays open. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but I would suggest to not give priority to benchmarks at this point.
This is a test added:
I had some flake, but realized this is because the code pre-dates other code, and had not yet adopted the With the Github results, this gives a very satisfying increase by business, even with the re-connection issues polluting the data. |
f5d30cd
to
a6eae7e
Compare
6a4cb43
to
23f4cf0
Compare
Adopt new error handling patterns done elsewhere Propoerly parameterize the worker number Move event trigger to drain_queue method Fix changed event meanings Add artifacting of benchmark data Add benchmark test for control task Add some control message benchmarks Combine with existing test methods module Update unit test Update to new config problems Avoid retyping no longer necessary Do some modernization combine test_pool files Update test to new pattern Use better start_working call
65f03d5
to
e82029b
Compare
Passing again (1m runtime), but locally I am still having problems with flake from
Also, changes in the meantime have changed the connection handling which changes the results for control messages greatly.
This is fairly consistently about 10x faster. It still shows the climb with business. There is also a major outliner in the max values, which could be some other unexpected connection opening or something. |
Fixes #10