-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEAT: Added new Solution Type "DCBiasedEddyCurrent" into Maxwell3D 25R1 #5602
Conversation
… corresponding setup_templates.py
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5602 +/- ##
==========================================
+ Coverage 81.48% 85.20% +3.71%
==========================================
Files 156 156
Lines 61063 61065 +2
==========================================
+ Hits 49760 52033 +2273
+ Misses 11303 9032 -2271 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I left a minor comment :)
92973fa
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here are the changes I proposed. It avoids having to copy paste all calls and the final template
should be correct since we go through the correct order.
Co-authored-by: Sébastien Morais <[email protected]>
Added new Solution Type "DCBiasedEddyCurrent" into Maxwell3D 25R1 and corresponding setup_templates.py
Description
AEDT 25R1 has introduced EddyCurrent with DC Solution new solution type.
Fix #5580
Issue linked
Please mention the issue number or describe the problem this pull request addresses.
Checklist