Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: Added new Solution Type "DCBiasedEddyCurrent" into Maxwell3D 25R1 #5602

Merged
merged 4 commits into from
Feb 6, 2025

Conversation

maxcapodi78
Copy link
Collaborator

Added new Solution Type "DCBiasedEddyCurrent" into Maxwell3D 25R1 and corresponding setup_templates.py

Description

AEDT 25R1 has introduced EddyCurrent with DC Solution new solution type.
Fix #5580

Issue linked

Please mention the issue number or describe the problem this pull request addresses.

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the bug Something isn't working label Dec 20, 2024
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.20%. Comparing base (b484a4b) to head (0ea90f2).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5602      +/-   ##
==========================================
+ Coverage   81.48%   85.20%   +3.71%     
==========================================
  Files         156      156              
  Lines       61063    61065       +2     
==========================================
+ Hits        49760    52033    +2273     
+ Misses      11303     9032    -2271     

MaxJPRey
MaxJPRey previously approved these changes Dec 23, 2024
Copy link
Collaborator

@MaxJPRey MaxJPRey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

SMoraisAnsys
SMoraisAnsys previously approved these changes Jan 6, 2025
Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I left a minor comment :)

src/ansys/aedt/core/modules/setup_templates.py Outdated Show resolved Hide resolved
@maxcapodi78 maxcapodi78 dismissed stale reviews from SMoraisAnsys and MaxJPRey via 92973fa February 6, 2025 10:37
@maxcapodi78 maxcapodi78 enabled auto-merge (squash) February 6, 2025 10:38
Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are the changes I proposed. It avoids having to copy paste all calls and the final template should be correct since we go through the correct order.

src/ansys/aedt/core/modules/setup_templates.py Outdated Show resolved Hide resolved
@maxcapodi78 maxcapodi78 merged commit 71979dc into main Feb 6, 2025
43 checks passed
@maxcapodi78 maxcapodi78 deleted the fix_5580 branch February 6, 2025 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maxwell3D: Eddy Current with DC Biased design type is missing
4 participants