Skip to content

feat: grpc common layer architecture, bodies stub and admin stub implementation #1867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 32 commits into from
Apr 2, 2025

Conversation

RobPasMue
Copy link
Member

@RobPasMue RobPasMue commented Mar 25, 2025

Description

  • Move gRPC calls to a common layer
  • Include the bodies stub implementation as a reference
  • Include the admin stub implementation as a reference

Issue linked

Related to #1817

@RobPasMue RobPasMue self-assigned this Mar 25, 2025
@RobPasMue RobPasMue linked an issue Mar 25, 2025 that may be closed by this pull request
16 tasks
@github-actions github-actions bot added the enhancement New features or code improvements label Mar 25, 2025
Copy link

codecov bot commented Mar 25, 2025

Codecov Report

Attention: Patch coverage is 91.44928% with 59 lines in your changes missing coverage. Please review.

Project coverage is 90.29%. Comparing base (8a5567c) to head (a4ecb7c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ys/geometry/core/_grpc/_services/v0/conversions.py 84.86% 28 Missing ⚠️
...c/ansys/geometry/core/_grpc/_services/v0/bodies.py 94.78% 11 Missing ⚠️
src/ansys/geometry/core/_grpc/_version.py 78.43% 11 Missing ⚠️
...rc/ansys/geometry/core/_grpc/_services/_service.py 80.64% 6 Missing ⚠️
src/ansys/geometry/core/designer/body.py 92.85% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1867      +/-   ##
==========================================
+ Coverage   90.18%   90.29%   +0.11%     
==========================================
  Files          92      102      +10     
  Lines        8902     9304     +402     
==========================================
+ Hits         8028     8401     +373     
- Misses        874      903      +29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@RobPasMue RobPasMue force-pushed the feat/grpc-common-layer branch from cae1170 to 47fab9a Compare March 26, 2025 15:08
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Mar 31, 2025
@RobPasMue RobPasMue marked this pull request as ready for review March 31, 2025 06:33
@RobPasMue RobPasMue requested a review from a team as a code owner March 31, 2025 06:33
@RobPasMue RobPasMue changed the title feat: grpc common layer architecture and bodies stub implementation feat: grpc common layer architecture, bodies stub and admin stub implementation Apr 2, 2025
@RobPasMue RobPasMue merged commit 305c074 into main Apr 2, 2025
47 of 48 checks passed
@RobPasMue RobPasMue deleted the feat/grpc-common-layer branch April 2, 2025 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New features or code improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle gRPC API calls from central location
3 participants