Skip to content

Handle gRPC API calls from central location #1817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
6 of 16 tasks
RobPasMue opened this issue Mar 11, 2025 · 4 comments · Fixed by #1867, #1882, #1899 or #1909
Open
6 of 16 tasks

Handle gRPC API calls from central location #1817

RobPasMue opened this issue Mar 11, 2025 · 4 comments · Fixed by #1867, #1882, #1899 or #1909
Assignees
Labels
enhancement New features or code improvements maintenance Package and maintenance related

Comments

@RobPasMue
Copy link
Member

RobPasMue commented Mar 11, 2025

Currently, the proto calls are found all over the codebase. Looking and potential v1s, we should centralize them in some common module and handle versioning from it.

Breaking down into the various stubs we have... each one of them will take different times for sure. First PoC was done with the bodies stub (and it will probably be one of the longest ones to implement):

@RobPasMue RobPasMue added enhancement New features or code improvements maintenance Package and maintenance related labels Mar 11, 2025
@RobPasMue RobPasMue self-assigned this Mar 11, 2025
@RobPasMue
Copy link
Member Author

RobPasMue commented Mar 24, 2025

Moved comment to Issue body

@umutsoysalansys
Copy link
Contributor

umutsoysalansys commented Apr 15, 2025

@RobPasMue how do we organize files in these v1 v2 folders, is there any folder structure to follow, or just place files there now and then reorganize later?

@RobPasMue
Copy link
Member Author

@RobPasMue how do we organize files in these v1 v2 folders, is there any folder structure to follow, or just place files there now and then reorganize later?

Hi @umutsoysalansys ! Good question, for now just focus on the v0 implementation and the v1 placeholders just like it's done for the other stubs. We will see if a v2 comes around but extending should be straightforward.

@RobPasMue
Copy link
Member Author

@umutsoysalansys @jacobrkerstetter -- I just organized the remaining stubs from top to bottom by order of priority / easiness. The ones you already started, you can finish them, of course. But let's do them from easiest to most difficult if possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment