Skip to content

feat: grpc measurement tools stub implementation #1909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Apr 15, 2025

Conversation

jacobrkerstetter
Copy link
Contributor

Description

moved measurement tools stub to common locations

Issue linked

#1817

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

removed grpc calls from measurement tools
@jacobrkerstetter jacobrkerstetter self-assigned this Apr 14, 2025
@jacobrkerstetter jacobrkerstetter requested a review from a team as a code owner April 14, 2025 14:41
@github-actions github-actions bot added the enhancement New features or code improvements label Apr 14, 2025
@jacobrkerstetter jacobrkerstetter enabled auto-merge (squash) April 14, 2025 14:48
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting a few changes - thanks @jacobrkerstetter!

Copy link

codecov bot commented Apr 14, 2025

Codecov Report

Attention: Patch coverage is 93.44262% with 4 lines in your changes missing coverage. Please review.

Project coverage is 90.37%. Comparing base (1adc6a1) to head (5f4fb8a).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...metry/core/_grpc/_services/v1/measurement_tools.py 72.72% 3 Missing ⚠️
...metry/core/_grpc/_services/v0/measurement_tools.py 94.44% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1909   +/-   ##
=======================================
  Coverage   90.36%   90.37%           
=======================================
  Files         108      111    +3     
  Lines        9385     9419   +34     
=======================================
+ Hits         8481     8512   +31     
- Misses        904      907    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jacobrkerstetter jacobrkerstetter linked an issue Apr 14, 2025 that may be closed by this pull request
16 tasks
@jacobrkerstetter jacobrkerstetter merged commit c5cd303 into main Apr 15, 2025
41 checks passed
@jacobrkerstetter jacobrkerstetter deleted the feat/measurement_tools_relocation branch April 15, 2025 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or code improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle gRPC API calls from central location
3 participants