-
Notifications
You must be signed in to change notification settings - Fork 17
feat: grpc measurement tools stub implementation #1909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
removed grpc calls from measurement tools
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requesting a few changes - thanks @jacobrkerstetter!
src/ansys/geometry/core/_grpc/_services/v0/measurement_tools.py
Outdated
Show resolved
Hide resolved
…m/ansys/pyansys-geometry into feat/measurement_tools_relocation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1909 +/- ##
=======================================
Coverage 90.36% 90.37%
=======================================
Files 108 111 +3
Lines 9385 9419 +34
=======================================
+ Hits 8481 8512 +31
- Misses 904 907 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
… common stub class now
…m/ansys/pyansys-geometry into feat/measurement_tools_relocation
Description
moved measurement tools stub to common locations
Issue linked
#1817
Checklist
feat: extrude circle to cylinder
)