Skip to content

feat: grpc named selection stub implementation #1899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Apr 9, 2025
Merged

feat: grpc named selection stub implementation #1899

merged 13 commits into from
Apr 9, 2025

Conversation

jacobrkerstetter
Copy link
Contributor

Description

move named selection stub to common location

Issue linked

#1817

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@jacobrkerstetter jacobrkerstetter self-assigned this Apr 9, 2025
@jacobrkerstetter jacobrkerstetter requested a review from a team as a code owner April 9, 2025 11:59
@jacobrkerstetter jacobrkerstetter mentioned this pull request Apr 9, 2025
Open
16 tasks
@jacobrkerstetter jacobrkerstetter enabled auto-merge (squash) April 9, 2025 12:00
@github-actions github-actions bot added the enhancement New features or code improvements label Apr 9, 2025
@jacobrkerstetter jacobrkerstetter linked an issue Apr 9, 2025 that may be closed by this pull request
Handle gRPC API calls from central location #1817
Open
16 tasks
@RobPasMue RobPasMue changed the title feat: grpc common layer architecture, bodies stub and admin stub implementation feat: grpc named selection stub implementation Apr 9, 2025
RobPasMue
RobPasMue reviewed Apr 9, 2025
View reviewed changes
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments - but overall, great job @jacobrkerstetter!!

@codecov Codecov
Copy link

codecov bot commented Apr 9, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 89.85507% with 7 lines in your changes missing coverage. Please review.

Project coverage is 90.36%. Comparing base (32df1cd) to head (df6bdb1).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...eometry/core/_grpc/_services/v1/named_selection.py 70.58% 5 Missing ⚠️
...metry/core/_grpc/_services/base/named_selection.py 83.33% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1899      +/-   ##
==========================================
- Coverage   90.38%   90.36%   -0.02%     
==========================================
  Files         105      108       +3     
  Lines        9330     9384      +54     
==========================================
+ Hits         8433     8480      +47     
- Misses        897      904       +7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Jacob Kerstetter and others added 6 commits April 9, 2025 08:50
- removed unused grpc methods
7c28c2f 
- remove unused conversions
- do entity id conversion in stub
- only return ids instead of grpc objects from stub methods
altered stub to return only id's of members
61639bd
Merge branch 'feat/named_selection_stub_relocation' of https://github…
a94198e 
….com/ansys/pyansys-geometry into feat/named_selection_stub_relocation

# Conflicts:
#	src/ansys/geometry/core/_grpc/_services/base/named_selection.py
#	src/ansys/geometry/core/_grpc/_services/v0/conversions.py
#	src/ansys/geometry/core/_grpc/_services/v0/named_selection.py
#	src/ansys/geometry/core/_grpc/_services/v1/named_selection.py
#	src/ansys/geometry/core/designer/design.py
#	src/ansys/geometry/core/designer/selection.py
@pre-commit-ci
chore: auto fixes from pre-commit hooks
00f2a27
fixed DP creation
4acf063
Merge branch 'feat/named_selection_stub_relocation' of https://github…
6ff46bf 
….com/ansys/pyansys-geometry into feat/named_selection_stub_relocation
RobPasMue
RobPasMue reviewed Apr 9, 2025
View reviewed changes
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments - but looking great! Almost ready to merge!

RobPasMue
RobPasMue approved these changes Apr 9, 2025
View reviewed changes
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work - thanks a lot @jacobrkerstetter!

@jacobrkerstetter jacobrkerstetter merged commit 2ae51ef into main Apr 9, 2025
40 of 41 checks passed
@jacobrkerstetter jacobrkerstetter deleted the feat/named_selection_stub_relocation branch April 9, 2025 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobPasMue RobPasMue RobPasMue approved these changes

Assignees

@jacobrkerstetter jacobrkerstetter

Labels
enhancement New features or code improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle gRPC API calls from central location
3 participants
@jacobrkerstetter @RobPasMue @pyansys-ci-bot