feat: grpc named selection stub implementation#1899
Merged
jacobrkerstetter merged 13 commits intomainfrom Apr 9, 2025
Merged
Conversation
17 tasks
17 tasks
RobPasMue
changed the title
RobPasMue
reviewed
Apr 9, 2025
Member
RobPasMue
left a comment
RobPasMue
left a comment
There was a problem hiding this comment.
Few comments - but overall, great job @jacobrkerstetter!!
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1899 +/- ##
==========================================
- Coverage 90.38% 90.36% -0.02%
==========================================
Files 105 108 +3
Lines 9330 9384 +54
==========================================
+ Hits 8433 8480 +47
- Misses 897 904 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- remove unused conversions - do entity id conversion in stub - only return ids instead of grpc objects from stub methods
….com/ansys/pyansys-geometry into feat/named_selection_stub_relocation # Conflicts: # src/ansys/geometry/core/_grpc/_services/base/named_selection.py # src/ansys/geometry/core/_grpc/_services/v0/conversions.py # src/ansys/geometry/core/_grpc/_services/v0/named_selection.py # src/ansys/geometry/core/_grpc/_services/v1/named_selection.py # src/ansys/geometry/core/designer/design.py # src/ansys/geometry/core/designer/selection.py
….com/ansys/pyansys-geometry into feat/named_selection_stub_relocation
RobPasMue
reviewed
Apr 9, 2025
Member
RobPasMue
left a comment
RobPasMue
left a comment
There was a problem hiding this comment.
Minor comments - but looking great! Almost ready to merge!
RobPasMue
approved these changes
Apr 9, 2025
Member
RobPasMue
left a comment
RobPasMue
left a comment
There was a problem hiding this comment.
Awesome work - thanks a lot @jacobrkerstetter!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
move named selection stub to common location
Issue linked
#1817
Checklist
feat: extrude circle to cylinder)