-
Notifications
You must be signed in to change notification settings - Fork 56
fix: chown server-info file by client user in compose mode - alt fix #4484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@hpohekar Please verify these changes from your side. I got the test |
f13b14e
to
cd6f949
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR addresses file permission issues when launching Fluent containers in compose mode by removing the FLUENT_SERVER_INFO_PERMISSION_SYSTEM
environment variable and implementing a fallback mechanism to change file ownership using docker exec
when permission errors occur.
- Removes environment variable that was previously used to set system-wide permissions
- Adds container server info file path tracking through function signatures
- Implements a try-catch mechanism with ownership change fallback for permission errors
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
src/ansys/fluent/core/launcher/fluent_container.py | Updates function signatures to include container server info file path and removes environment variable setting |
src/ansys/fluent/core/launcher/container_launcher.py | Adds try-catch logic to handle permission errors with ownership change fallback |
src/ansys/fluent/core/docker/docker_compose.py | Implements chown_server_info_file method and updates constructor to accept container file path |
doc/changelog.d/4484.fixed.md | Documents the alternative fix implementation |
doc/changelog.d/4483.fixed.md | Documents the original compose mode fix |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Started a Podman workflow on the latest changes. |
This PR removes the
FLUENT_SERVER_INFO_PERMISSION_SYSTEM
env var for compose launch. The server writes the server-info file with the default 600 permission. The file owner is subsequently changed to client-user subsequent using adocker exec
call, so the file can be read in the client side.