Skip to content

Conversation

mkundu1
Copy link
Contributor

@mkundu1 mkundu1 commented Sep 21, 2025

This PR removes the FLUENT_SERVER_INFO_PERMISSION_SYSTEM env var for compose launch. The server writes the server-info file with the default 600 permission. The file owner is subsequently changed to client-user subsequent using a docker exec call, so the file can be read in the client side.

@github-actions github-actions bot added the bug Issue, problem or error in PyFluent label Sep 21, 2025
@mkundu1
Copy link
Contributor Author

mkundu1 commented Sep 21, 2025

@hpohekar Please verify these changes from your side. I got the test test_docker_compose passing locally with docker compose. I haven't tested podman compose.

@mkundu1 mkundu1 marked this pull request as ready for review September 21, 2025 05:01
@hpohekar
Copy link
Collaborator

@hpohekar Please verify these changes from your side. I got the test test_docker_compose passing locally with docker compose. I haven't tested podman compose.

@mkundu1 Yes, sure. Looks good to me. Thanks a lot!

I have started Podman workflow. Let's see.

https://github.com/ansys/pyfluent/actions/runs/17903715174

@Copilot Copilot AI review requested due to automatic review settings October 8, 2025 12:13
@mkundu1 mkundu1 force-pushed the fix/compose-file-permission-2 branch from f13b14e to cd6f949 Compare October 8, 2025 12:13
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses file permission issues when launching Fluent containers in compose mode by removing the FLUENT_SERVER_INFO_PERMISSION_SYSTEM environment variable and implementing a fallback mechanism to change file ownership using docker exec when permission errors occur.

  • Removes environment variable that was previously used to set system-wide permissions
  • Adds container server info file path tracking through function signatures
  • Implements a try-catch mechanism with ownership change fallback for permission errors

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/ansys/fluent/core/launcher/fluent_container.py Updates function signatures to include container server info file path and removes environment variable setting
src/ansys/fluent/core/launcher/container_launcher.py Adds try-catch logic to handle permission errors with ownership change fallback
src/ansys/fluent/core/docker/docker_compose.py Implements chown_server_info_file method and updates constructor to accept container file path
doc/changelog.d/4484.fixed.md Documents the alternative fix implementation
doc/changelog.d/4483.fixed.md Documents the original compose mode fix

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@hpohekar
Copy link
Collaborator

hpohekar commented Oct 8, 2025

Started a Podman workflow on the latest changes.

https://github.com/ansys/pyfluent/actions/runs/18344452327

@mkundu1 mkundu1 merged commit ec2c873 into main Oct 8, 2025
55 of 62 checks passed
@mkundu1 mkundu1 deleted the fix/compose-file-permission-2 branch October 8, 2025 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue, problem or error in PyFluent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants