-
Notifications
You must be signed in to change notification settings - Fork 3.6k
[fix](mysql protocol)Set more stmt exists flag correctly when forward to master. #55711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
Cloud UT Coverage ReportIncrement line coverage Increment coverage report
|
FE UT Coverage ReportIncrement line coverage |
TPC-H: Total hot run time: 34448 ms |
TPC-DS: Total hot run time: 187324 ms |
ClickBench: Total hot run time: 30.67 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
FE Regression Coverage ReportIncrement line coverage |
|
run p0 |
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
FE Regression Coverage ReportIncrement line coverage |
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
|
run buildall |
|
PR approved by at least one committer and no changes requested. |
Cloud UT Coverage ReportIncrement line coverage Increment coverage report
|
TPC-H: Total hot run time: 34878 ms |
TPC-DS: Total hot run time: 189784 ms |
|
run external |
ClickBench: Total hot run time: 30.92 s |
|
run check_coverage |
2 similar comments
|
run check_coverage |
|
run check_coverage |
|
skip coverage |
… to master. (apache#55711) When execute multiple statements in one batch and CLIENT_MULTI_STATEMENTS is set, Doris server need to set SERVER_MORE_RESULTS_EXISTS flag in the return packet before the last statement. But when the Observer forward stmt to Master, this SERVER_MORE_RESULTS_EXISTS is not set, cause the following statements failed to execute. This pr forward a boolean value to Master, so the Master FE knows it is the last statement or not, and could set SERVER_MORE_RESULTS_EXISTS correctly.
What problem does this PR solve?
When execute multiple statements in one batch and CLIENT_MULTI_STATEMENTS is set, Doris server need to set SERVER_MORE_RESULTS_EXISTS flag in the return packet before the last statement. But when the Observer forward stmt to Master, this SERVER_MORE_RESULTS_EXISTS is not set, cause the following statements failed to execute.
This pr forward a boolean value to Master, so the Master FE knows it is the last statement or not, and could set SERVER_MORE_RESULTS_EXISTS correctly.
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)