HBASE-29662 - Avoid regionDir/tableDir creation as part of .regioninfo file creation #7406
+34
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o file creation in HRegion initialize
gvprathyusha6
force-pushed
the
HBASE-29662
branch
from
8cf73b6 to
33362aa
Compare
apurtell
requested changes
Oct 27, 2025
| FsPermission perms = CommonFSUtils.getFilePermissions(fs, conf, HConstants.DATA_FILE_UMASK_KEY); | ||
| // Write the RegionInfo file content | ||
| try (FSDataOutputStream out = FSUtils.create(conf, fs, regionInfoFile, perms, null)) { | ||
| try (FSDataOutputStream out = FSUtils.create(conf, fs, regionInfoFile, perms, null, false)) { |
There was a problem hiding this comment.
Add a comment here why this change, providing the JIRA identifier. The reason not to recursively create directories is important, we don't want someone refactoring this code later to miss that.
|
I know it's difficult but any possibility of creating some tests around this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…o file creation