KAFKA-19797: Added deliveryCompleteCount to writeState, ShareUpdate and ShareSnapshot schemas #20810
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
triage
AndrewJSchofield
requested review from
AndrewJSchofield and
apoorvmittal10
and removed request for
apoorvmittal10
AndrewJSchofield
approved these changes
Nov 3, 2025
Member
AndrewJSchofield
left a comment
AndrewJSchofield
left a comment
There was a problem hiding this comment.
Thanks for the new PR. Looks good to me.
| .setStateBatches(List.of(new WriteShareGroupStateRequestData.StateBatch() | ||
| .setFirstOffset(0) | ||
| .setLastOffset(10) | ||
| .setLastOffset(9) |
Contributor
There was a problem hiding this comment.
Ideally, we should not be changing this value for the test, rather adjust the deliveryCompleteCount according to the original test. Same for other tests in this PR.
share-coordinator/src/main/resources/common/message/ShareSnapshotValue.json
Outdated
Show resolved
Hide resolved
share-coordinator/src/main/resources/common/message/ShareUpdateValue.json
Outdated
Show resolved
Hide resolved
share-coordinator/src/main/java/org/apache/kafka/coordinator/share/ShareCoordinatorShard.java
Show resolved
Hide resolved
clients/src/main/resources/common/message/WriteShareGroupStateRequest.json
Outdated
Show resolved
Hide resolved
adixitconfluent
approved these changes
Nov 3, 2025
Contributor
adixitconfluent
left a comment
adixitconfluent
left a comment
There was a problem hiding this comment.
Thanks for the changes. LGTM.
AndrewJSchofield
pushed a commit
that referenced
this pull request
Nov 4, 2025
#20820) This PR is part of [KIP-1226](https://cwiki.apache.org/confluence/display/KAFKA/KIP-1226%3A+Introducing+Share+Partition+Lag+Persistence+and+Retrieval). In [KAFKA-19797](#20810), a new field deliveryCompleteCount was being sent by Share Partition to the persister. This PR introduces deliveryCompleteCount in ReadShareGroupStateSummary RPC so that it can later be used to calculate the share partition lag. Reviewers: Abhinav Dixit <[email protected]>, Sushant Mahajan <[email protected]>, Andrew Schofield <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of
KIP-1226.
It introduces a new field called
deliveryCompleteCountinwriteShareGroupState RPC and
ShareUpdateandShareSnapshot. Theshare partition now maintains
inFlightTerminalCount(introducedhere) and it uses this
exact value to pass to the writeState request for
deliveryCompleteCount.Reviewers: Andrew Schofield [email protected], Abhinav Dixit
[email protected]