[SPARK-53537][Core] Adding Support for Parsing CONTINUE HANDLER #52298
+498
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miland-db
reviewed
Sep 10, 2025
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/SqlScriptingParserSuite.scala
Show resolved
Hide resolved
miland-db
reviewed
Sep 10, 2025
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
Outdated
Show resolved
Hide resolved
miland-db
reviewed
Sep 10, 2025
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/SqlScriptingParserSuite.scala
Show resolved
Hide resolved
|
Hey @cloud-fan, should we create a temporary |
TeodorDjelic
changed the title
|
yes, please add temp config to hide half baked features. |
… as a continue handler feature switch;
miland-db
reviewed
Sep 11, 2025
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
Outdated
Show resolved
Hide resolved
dusantism-db
approved these changes
Sep 12, 2025
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/SqlScriptingParserSuite.scala
Show resolved
Hide resolved
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/SqlScriptingParserSuite.scala
Show resolved
Hide resolved
cloud-fan
reviewed
Sep 12, 2025
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
Outdated
Show resolved
Hide resolved
cloud-fan
reviewed
Sep 12, 2025
cloud-fan
reviewed
Sep 12, 2025
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/SqlScriptingParserSuite.scala
Outdated
Show resolved
Hide resolved
cloud-fan
reviewed
Sep 12, 2025
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/SqlScriptingParserSuite.scala
Outdated
Show resolved
Hide resolved
cloud-fan
reviewed
Sep 12, 2025
sql/core/src/test/scala/org/apache/spark/sql/scripting/SqlScriptingInterpreterSuite.scala
Outdated
Show resolved
Hide resolved
…onf.scala Co-authored-by: Wenchen Fan <[email protected]>
…onf.scala Co-authored-by: Wenchen Fan <[email protected]>
…er/SqlScriptingParserSuite.scala Co-authored-by: Wenchen Fan <[email protected]>
…ptingInterpreterSuite.scala Co-authored-by: Wenchen Fan <[email protected]>
srielau
approved these changes
Sep 13, 2025
|
thanks, merging to master! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR lays the foundation for implementing support for
CONTINUE HANDLER.CONTINUE HANDLERno longer throws an exception that it is not supported, and now behaves like anEXIT HANDLER.Feature is under a new feature switch
spark.sql.scripting.continueHandlerEnabledinsideSQLConfig.scala.Why are the changes needed?
We want to add support for executing
CONTINUE HANDLER. This feature is supported in documentation, but is not supported as of now inside SQL Scripts. Change is supposed to enable parsing ofCONTINUE HANDLER.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Tests were added to
SqlScriptingInterpreterSuite.scalaandSqlScriptingParserSuite.scalato facilitate theCONTINUE HANDLER.Both test suites have
spark.sql.scripting.continueHandlerEnabledconfig entry set totruebefore all tests, and unset after all of the tests have been run.Was this patch authored or co-authored using generative AI tooling?
No.