Skip to content

[SPARK-53537][Core] Adding Support for Parsing CONTINUE HANDLER #52298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 10 commits into from
+498 −25
Closed

[SPARK-53537][Core] Adding Support for Parsing CONTINUE HANDLER #52298

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
fbd0237
Removed exception throwing for continue handlers, and added tests;
TeodorDjelic Sep 10, 2025
4e5ae21
Fixed an extra newline before else;
TeodorDjelic Sep 10, 2025
be0b3f2
Added a new SQLConf entry spark.sql.scripting.continueHandlerEnabled,…
TeodorDjelic Sep 11, 2025
d6d7858
Changed spark.sql.scripting.continueHandlerEnabled feature switch des…
TeodorDjelic Sep 11, 2025
5963742
Continue handler not supported test readded;
TeodorDjelic Sep 12, 2025
50f23c7
Update sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLC…
TeodorDjelic Sep 12, 2025
5cdd546
Update sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLC…
TeodorDjelic Sep 12, 2025
37322c2
Update sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/pars…
TeodorDjelic Sep 12, 2025
a4047f9
Update sql/core/src/test/scala/org/apache/spark/sql/scripting/SqlScri…
TeodorDjelic Sep 12, 2025
6db58f0
Fixing a test;
TeodorDjelic Sep 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,11 +282,15 @@ class AstBuilder extends DataTypeAstBuilder
parsingCtx: SqlScriptingParsingContext): ExceptionHandler = {
val exceptionHandlerTriggers = visitConditionValuesImpl(ctx.conditionValues())

if (Option(ctx.CONTINUE()).isDefined) {
throw SqlScriptingErrors.continueHandlerNotSupported(CurrentOrigin.get)
val handlerType = if (Option(ctx.CONTINUE()).isDefined) {
if (!conf.getConf(SQLConf.SQL_SCRIPTING_CONTINUE_HANDLER_ENABLED)) {
throw SqlScriptingErrors.continueHandlerNotSupported(CurrentOrigin.get)
}
ExceptionHandlerType.CONTINUE
} else {
ExceptionHandlerType.EXIT
}

val handlerType = ExceptionHandlerType.EXIT
val body = if (Option(ctx.beginEndCompoundBlock()).isDefined) {
visitBeginEndCompoundBlockImpl(
ctx.beginEndCompoundBlock(),
Expand Down
11 changes: 11 additions & 0 deletions sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4144,6 +4144,17 @@ object SQLConf {
.booleanConf
.createWithDefault(true)

val SQL_SCRIPTING_CONTINUE_HANDLER_ENABLED =
buildConf("spark.sql.scripting.continueHandlerEnabled")
.internal()
.doc("EXPERIMENTAL FEATURE/WORK IN PROGRESS: SQL Scripting CONTINUE HANDLER feature " +
"is under development and still not working as intended. This feature switch is intended " +
"to be used internally for development and testing, not by end users. " +
"YOU ARE ADVISED AGAINST USING THIS FEATURE AS ITS NOT FINISHED.")
.version("4.1.0")
.booleanConf
.createWithDefault(false)

val CONCAT_BINARY_AS_STRING = buildConf("spark.sql.function.concatBinaryAsString")
.doc("When this option is set to false and all inputs are binary, `functions.concat` returns " +
"an output as binary. Otherwise, it returns as a string.")
Expand Down
Loading