-
Notifications
You must be signed in to change notification settings - Fork 2k
Transform interfaces into possible types only #3257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transform interfaces into possible types only #3257
Conversation
@trevor-scheer This is a pretty small change but fixes a big pain point with using interfaces - are you the best person to take a look? |
@rtymchyk I'm currently looking into this and some related issues, that I suspect we'll want to fix together. I hope to have more to say on this next week. |
Thanks for the update @martijnwalraven :) |
Any update regarding these issues @martijnwalraven? We've been playing with federation a bunch at work, but some of the issues around interfaces are a bit of a blocker at the moment to fully investing. There are workarounds we can do in the meantime, but obviously that's less than ideal. Thanks for your hard work! |
Same here. We trying to roll this out but running into this issue. |
@godspeedelbow @ksaldana1 Does this PR solve your case? |
@vitramir I don't how to test it, is there a way to easily use this PR's version of the code as a dependency so I can try it out? |
@godspeedelbow I've published it as @apollo-model/federation and @apollo-model/gateway Source: https://github.com/apollo-model/apollo-server/tree/custom-package |
This PR fixes the issue for me. |
I can confirm that this PR fixes our issue too. @martijnwalraven any news when a fix will be shipped? |
* Fix indentation of query plan snapshots in test * Add failing tests from #3257 * Introduce Scope to capture nested type conditions * Clarify that `completeField` is only called for object types * Adjust fields when expanding possible types Co-authored-by: Martijn Walraven <[email protected]> Co-authored-by: Vitramir <[email protected]>
…server#3529) * Fix indentation of query plan snapshots in test * Add failing tests from apollographql/apollo-server#3257 * Introduce Scope to capture nested type conditions * Clarify that `completeField` is only called for object types * Adjust fields when expanding possible types Co-authored-by: Martijn Walraven <[email protected]> Co-authored-by: Vitramir <[email protected]> Apollo-Orig-Commit-AS: apollographql/apollo-server@43d3ac1
Fix for issue #3253