Skip to content

Transform interfaces into possible types only #3257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

vitramir
Copy link
Contributor

@vitramir vitramir commented Sep 6, 2019

Fix for issue #3253

@rtymchyk
Copy link

@trevor-scheer This is a pretty small change but fixes a big pain point with using interfaces - are you the best person to take a look?

@martijnwalraven
Copy link
Contributor

@rtymchyk I'm currently looking into this and some related issues, that I suspect we'll want to fix together. I hope to have more to say on this next week.

@rtymchyk
Copy link

Thanks for the update @martijnwalraven :)

@ksaldana1
Copy link

Any update regarding these issues @martijnwalraven? We've been playing with federation a bunch at work, but some of the issues around interfaces are a bit of a blocker at the moment to fully investing. There are workarounds we can do in the meantime, but obviously that's less than ideal.

Thanks for your hard work!

@godspeedelbow
Copy link

Same here. We trying to roll this out but running into this issue.

@vitramir
Copy link
Contributor Author

@godspeedelbow @ksaldana1 Does this PR solve your case?

martijnwalraven added a commit that referenced this pull request Oct 18, 2019
@godspeedelbow
Copy link

@vitramir I don't how to test it, is there a way to easily use this PR's version of the code as a dependency so I can try it out?

@vitramir
Copy link
Contributor Author

@godspeedelbow I've published it as @apollo-model/federation and @apollo-model/gateway

Source: https://github.com/apollo-model/apollo-server/tree/custom-package

@rtymchyk
Copy link

This PR fixes the issue for me.

@godspeedelbow
Copy link

godspeedelbow commented Oct 29, 2019

I can confirm that this PR fixes our issue too.

@martijnwalraven any news when a fix will be shipped?

martijnwalraven added a commit that referenced this pull request Oct 31, 2019
trevor-scheer added a commit that referenced this pull request Nov 20, 2019
* Fix indentation of query plan snapshots in test

* Add failing tests from #3257

* Introduce Scope to capture nested type conditions

* Clarify that `completeField` is only called for object types

* Adjust fields when expanding possible types

Co-authored-by: Martijn Walraven <[email protected]>
Co-authored-by: Vitramir <[email protected]>
@trevor-scheer
Copy link
Contributor

Closing this in favor of the PR that was just landed: #3529

Thanks again for this contribution @vitramir! We appreciate all of your help in identifying this issue and taking steps to resolve it. I've added co-authorship for you on the merge commit: 43d3ac1

abernix pushed a commit to apollographql/federation that referenced this pull request Sep 4, 2020
…server#3529)

* Fix indentation of query plan snapshots in test

* Add failing tests from apollographql/apollo-server#3257

* Introduce Scope to capture nested type conditions

* Clarify that `completeField` is only called for object types

* Adjust fields when expanding possible types

Co-authored-by: Martijn Walraven <[email protected]>
Co-authored-by: Vitramir <[email protected]>
Apollo-Orig-Commit-AS: apollographql/apollo-server@43d3ac1
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants