Correctly expand possible types for interfaces #3529
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
queerviolet
approved these changes
Nov 19, 2019
There was a problem hiding this comment.
This looks great! 👍🏽
For future work, it strikes me that the solution to this general problem—given a point in a query, what fields / fragments are valid?—might well be useful in other contexts (like a language server, for example), so it might be worth pulling out at some point. Either way, this is great for the gateway, so LGTM.
| @@ -93,69 +93,69 @@ describe('buildQueryPlan', () => { | |||
| const queryPlan = buildQueryPlan(buildOperationContext(schema, query)); | |||
|
|
|||
| expect(queryPlan).toMatchInlineSnapshot(` | |||
| QueryPlan { | |||
There was a problem hiding this comment.
aw man this indentation change is a bummer.
(tests are not a bummer, tests are great, i'm just sad abt that jest bug)
There was a problem hiding this comment.
Good news is the bug is behind us and our poorly indented tests will resolve themselves over time 😄
| @@ -422,14 +426,14 @@ function splitFields( | |||
| GraphQLObjectType | |||
| >(); | |||
|
|
|||
| for (const runtimeParentType of context.getPossibleTypes(parentType)) { | |||
| for (const runtimeParentType of scope.possibleTypes) { | |||
abernix
pushed a commit
to apollographql/federation
that referenced
this pull request
Sep 4, 2020
…server#3529) * Fix indentation of query plan snapshots in test * Add failing tests from apollographql/apollo-server#3257 * Introduce Scope to capture nested type conditions * Clarify that `completeField` is only called for object types * Adjust fields when expanding possible types Co-authored-by: Martijn Walraven <[email protected]> Co-authored-by: Vitramir <[email protected]> Apollo-Orig-Commit-AS: apollographql/apollo-server@43d3ac1
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is in response to the following contributions made by @vitramir, thank you for bringing this to our attention and proposing a solution 🎉
Closes #3253
Closes #3257
Thank you to everyone following along for your patience while we've discussed the problem and a solution we'd like to go forward with. @martijnwalraven has prepared this branch for us as a proposal, and it's one we'd like to go forward with.
This PR introduces the concept of a
Scope. AScope(which belongs to aField) captures information about the parent's type and the possible types of theField. This addition to the data model of aFieldallows the query planner to make correct decisions about exploding interfaces into only possible types.