Skip to content

Conversation

jonmosco
Copy link

@jonmosco jonmosco commented Feb 1, 2024

take advantage of the os packages functions for directory maintenance.

@jonmosco jonmosco requested review from dwelch0 and cubismod February 1, 2024 17:28
Copy link
Contributor

@cubismod cubismod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@dwelch0 dwelch0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

return err
}
cmd = exec.Command("mkdir", directory)
cmd.Dir = d.workdir
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same filepath change needed here

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

// clear all items in working directory
func (d *Downloader) clear() error {
cmd := exec.Command("rm", "-rf", UNTAR_DIRECTORY)
cmd.Dir = d.workdir
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

filepath change

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dwelch0 dwelch0 self-requested a review February 14, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants