Skip to content

ADFA-5586 | Markdown Previewer: explain empty Project picks and render JS-driven HTML - #105

Merged
Daniel-ADFA merged 1 commit into
mainfrom
fix/ADFA-5586-markdown-previewer-project-and-html
Sep 23, 2026
Merged

Daniel-ADFA merged 1 commit into
mainfrom
fix/ADFA-5586-markdown-previewer-project-and-html

Conversation

@Daniel-ADFA

@Daniel-ADFA Daniel-ADFA commented Sep 22, 2026 •

Copy link
Copy Markdown
Collaborator

ADFA-5586

  • Project button: shows a dialog when no project is open or the project has no Markdown/HTML files, instead of silently doing nothing. The walk runs off the main thread and skips build/ and hidden directories.
  • HTML stuck on "Loading…": Gradle's problems report is a JS page whose static body is Loading.... The WebView now enables JavaScript, with file and content access disabled.

Verified on an arm64 emulator (stage host build): empty-project dialog, file list, problems report and Markdown render, dialog at font scale 1.0 and 2.0.

…e previewer

Project returned silently when no project was open or no file matched,
and the only HTML in a fresh project (Gradle's problems report) lives
under build/, which the picker skips. Show a dialog for both cases.
Walk the project off the main thread and prune build/ and hidden
directories instead of walking them and filtering afterwards.

The problems report renders with JavaScript; with JS disabled its static
"Loading..." body never changed. Enable JS, with file and content access
disabled.

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.

Tip: disable this comment in your organization's Code Review settings.

@Daniel-ADFA
Daniel-ADFA merged commit 703c03b into main Sep 23, 2026
1 of 2 checks passed
@Daniel-ADFA
Daniel-ADFA deleted the fix/ADFA-5586-markdown-previewer-project-and-html branch September 23, 2026 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants