chore: ignore case for value of ASDF_FORCE_PREPEND environment variable#2026
Merged
Stratus3D merged 1 commit intoasdf-vm:masterfrom Mar 20, 2025
Merged
Conversation
machupicchubeta
force-pushed
the
be_tolerant_of_force_prepend_env
branch
from
a9cd68c to
33c2a92
Compare
I agree that it would be valid even if it is set in uppercase as well as lowercase. @Stratus3D commented: - asdf-vm#2011 (comment) > We might want to be able to handle inconsistent case here. Some folks might set this to `YES` by mistake and I think that should be handled.
machupicchubeta
force-pushed
the
be_tolerant_of_force_prepend_env
branch
from
33c2a92 to
cba96c0
Compare
Stratus3D
approved these changes
Mar 20, 2025
Stratus3D
changed the title
ASDF_FORCE_PREPEND environment variableASDF_FORCE_PREPEND environment variable
Stratus3D
changed the title
ASDF_FORCE_PREPEND environment variableASDF_FORCE_PREPEND environment variable
Contributor
Author
|
@andrecloutier @Stratus3D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I agree that it would be valid even if it is set in uppercase as well as lowercase.
@Stratus3D commented:
ASDF_FORCE_PREPENDenvironment variable #2011 (comment)Other Information
I think this code change did not need to be mentioned in the spec, so I did not add it there. What do you think? I would like to hear the committer's opinion.
Current Specification is:
asdf/docs/manage/configuration.md
Lines 208 to 215 in 932ac46