fix: convert hyphens to underscores when converting plugin names to generate valid environment variables#2194
Closed
mgrechukh wants to merge 2 commits intoasdf-vm:masterfrom
Closed
fix: convert hyphens to underscores when converting plugin names to generate valid environment variables#2194mgrechukh wants to merge 2 commits intoasdf-vm:masterfrom
mgrechukh wants to merge 2 commits intoasdf-vm:masterfrom
Conversation
mgrechukh
changed the title
mgrechukh
changed the title
mgrechukh
force-pushed
the
fix-multiword-tools
branch
from
1b4cec3 to
67a60c3
Compare
Stratus3D
reviewed
Apr 17, 2026
Member
Stratus3D
left a comment
Stratus3D
left a comment
There was a problem hiding this comment.
Sorry for the extremely late review here @mgrechukh ! This is a good fix, but we need to have tests before I can merge. I'm going to try to write tests for this myself.
Stratus3D
changed the title
Stratus3D
changed the title
Member
|
Thanks for the PR @mgrechukh ! The changes have been merged. |
This was referenced Apr 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In pre-0.16.0 shell implementation, tool name consisting of multiple words, separated by dash, were sanitized as environment variable. I.e. for "teleport-community" we have "ASDF_TELEPORT_COMMUNITY_VERSION"
As now toolName passed to variable name unmodified which breaks certain usage scenarios. Although variable containing dash "ASDF_TELEPORT-COMMUNITY_VERSION" sometimes can be set in surrounding code, it is clumsy.
This patch restores the old behaviour.