Skip to content

fix: convert hyphens to underscores when converting plugin names to generate valid environment variables #2194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mgrechukh wants to merge 2 commits into from
+3 −1
Closed

fix: convert hyphens to underscores when converting plugin names to generate valid environment variables #2194

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
67a60c3
fix: resolves asdf-vm/asdf#2204
mgrechukh Oct 12, 2025
cfdcd82
Merge branch 'master' into fix-multiword-tools
Stratus3D Apr 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion internal/resolve/resolve.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,5 +131,7 @@ func parseVersion(rawVersions string) []string {
}

func variableVersionName(toolName string) string {
return fmt.Sprintf("ASDF_%s_VERSION", strings.ToUpper(toolName))
upper := strings.ToUpper(toolName)
sanitized := strings.ReplaceAll(upper, "-", "_")
return fmt.Sprintf("ASDF_%s_VERSION", sanitized)
}