feat: switch to creation of venv without Python or pip #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 2, 2024
This was referenced Jan 3, 2024
mattem
force-pushed
the
pycrust
branch
3 times, most recently
from
a77c161 to
0fa112d
Compare
mattem
force-pushed
the
pycrust
branch
6 times, most recently
from
4401ad5 to
1acec8e
Compare
alexeagle
reviewed
Feb 7, 2024
|
If you want to review it that way, then ignore |
alexeagle
approved these changes
Feb 14, 2024
Merged
alexeagle
added a commit
that referenced
this pull request
Feb 21, 2024
### Type of change - Refactor (a code change that neither fixes a bug or adds a new feature) ### Test plan - Covered by existing test cases #233 was mentioned as a fix for #218 but #233 includes a dependency on openssl. This dependency on openssl makes building containers on MacOS difficult as we then need to cross build openssl. I see that there was an attempt to remove the openssl dependency `rattler_installs_packages` however, `native-tls` is in the default features and is the only default feature. Disabling `default-features` removes the dependency on openssl. --------- Co-authored-by: Alex Eagle <[email protected]>
This was referenced Mar 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches creating the venv to a dedicated tool, removing the requirement for pip.
Venv is now created just before the binary or test runs, rather than as an action output. The overhead is minimal, venv creation and activation takes at most 7ms as observed during testing.
Closes #233
Closes #238
Closes #176
Closes #218
Closes #248
Closes #152
Closes #110