Skip to content

Remove virtual type support hint - #746

Merged
temaEmelyan merged 3 commits into
masterfrom
remove-virtual-type-support-hint
Jul 28, 2026
Merged

Remove virtual type support hint#746
temaEmelyan merged 3 commits into
masterfrom
remove-virtual-type-support-hint

Conversation

@temaEmelyan

Copy link
Copy Markdown
Member

Please make sure you consider the following:

  • Add tests that use __typename in queries
  • Does this change work with all nadel transformations (rename, type rename, hydration, etc)? Add tests for this.
  • Is it worth using hints for this change in order to be able to enable a percentage rollout?
  • Do we need to add integration tests for this change in the graphql gateway?
  • Do we need a pollinator check for this?

@github-actions

github-actions Bot commented Jul 27, 2026

Copy link
Copy Markdown

Test Results

  657 files   - 1    657 suites   - 1   1m 9s ⏱️ -3s
2 209 tests  - 2  1 651 ✅ ±0  558 💤  - 1  0 ❌  - 1 
2 217 runs   - 2  1 659 ✅ ±0  558 💤  - 1  0 ❌  - 1 

Results for commit a41e098. ± Comparison against base commit 6553955.

This pull request removes 2 tests.
graphql.nadel.tests.next.fixtures.hydration.statics.StaticHydrationVirtualTypeHintOffTest ‑ execute()
graphql.nadel.tests.next.fixtures.hydration.statics.StaticHydrationVirtualTypeHintOffTest ‑ executeNoDefer()

♻️ This comment has been updated with latest results.

gnawf
gnawf previously approved these changes Jul 27, 2026
gnawf
gnawf previously approved these changes Jul 28, 2026
@temaEmelyan
temaEmelyan merged commit 160ccad into master Jul 28, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants