Remove virtual type support hint

lib/src/main/java/graphql/nadel/NadelExecutionHints.kt

@@ -13,7 +13,6 @@ import graphql.nadel.hints.NadelReachableUnderlyingServiceTypesHint
 import graphql.nadel.hints.NadelShadowUnderlyingTypeNameInvestigation
 import graphql.nadel.hints.NadelSharedTypeRenamesHint
 import graphql.nadel.hints.NadelShortCircuitEmptyQueryHint
-import graphql.nadel.hints.NadelVirtualTypeSupportHint
 import graphql.nadel.hints.NewResultMergerAndNamespacedTypename
 
 data class NadelExecutionHints(
@@ -23,7 +22,6 @@ data class NadelExecutionHints(
     val deferSupport: NadelDeferSupportHint,
     val sharedTypeRenames: NadelSharedTypeRenamesHint,
     val shortCircuitEmptyQuery: NadelShortCircuitEmptyQueryHint,
-    val virtualTypeSupport: NadelVirtualTypeSupportHint,
     val executeOnEngineSchema: NadelExecuteOnEngineSchemaHint,
     val hydrationFilterObjectTypes: NadelHydrationFilterObjectTypesHint,
     val hydrationExecutableSourceFields: NadelHydrationExecutableSourceFields,
@@ -50,7 +48,6 @@ data class NadelExecutionHints(
         private var deferSupport = NadelDeferSupportHint { false }
         private var shortCircuitEmptyQuery = NadelShortCircuitEmptyQueryHint { false }
         private var sharedTypeRenames = NadelSharedTypeRenamesHint { false }
-        private var virtualTypeSupport = NadelVirtualTypeSupportHint { false }
         private var executeOnEngineSchema = NadelExecuteOnEngineSchemaHint { false }
         private var hydrationFilterObjectTypes = NadelHydrationFilterObjectTypesHint { false }
         private var hydrationExecutableSourceFields = NadelHydrationExecutableSourceFields { false }
@@ -69,7 +66,6 @@ data class NadelExecutionHints(
             deferSupport = nadelExecutionHints.deferSupport
             shortCircuitEmptyQuery = nadelExecutionHints.shortCircuitEmptyQuery
             sharedTypeRenames = nadelExecutionHints.sharedTypeRenames
-            virtualTypeSupport = nadelExecutionHints.virtualTypeSupport
             executeOnEngineSchema = nadelExecutionHints.executeOnEngineSchema
             hydrationFilterObjectTypes = nadelExecutionHints.hydrationFilterObjectTypes
             hydrationExecutableSourceFields = nadelExecutionHints.hydrationExecutableSourceFields
@@ -110,11 +106,6 @@ data class NadelExecutionHints(
             return this
         }
 
-        fun virtualTypeSupport(flag: NadelVirtualTypeSupportHint): Builder {
-            virtualTypeSupport = flag
-            return this
-        }
-
         fun executeOnEngineSchema(flag: NadelExecuteOnEngineSchemaHint): Builder {
             executeOnEngineSchema = flag
             return this
@@ -163,7 +154,6 @@ data class NadelExecutionHints(
                 deferSupport,
                 sharedTypeRenames,
                 shortCircuitEmptyQuery,
-                virtualTypeSupport,
                 executeOnEngineSchema,
                 hydrationFilterObjectTypes,
                 hydrationExecutableSourceFields,

lib/src/main/java/graphql/nadel/engine/transform/hydration/NadelHydrationFieldsBuilder.kt

@@ -23,7 +23,6 @@ import graphql.normalized.NormalizedInputValue
 internal object NadelHydrationFieldsBuilder {
     fun makeBackingQueries(
         executionContext: NadelExecutionContext,
-        service: Service,
         instruction: NadelHydrationFieldInstruction,
         aliasHelper: NadelAliasHelper,
         virtualField: ExecutableNormalizedField,
@@ -53,11 +52,9 @@ internal object NadelHydrationFieldsBuilder {
             }
             // Fix types for virtual fields
             .onEach { field ->
-                if (executionContext.hints.virtualTypeSupport(service)) {
-                    setBackingObjectTypeNames(instruction, field)
-                    field.traverseSubTree { child ->
-                        setBackingObjectTypeNames(instruction, child)
-                    }
+                setBackingObjectTypeNames(instruction, field)
+                field.traverseSubTree { child ->
+                    setBackingObjectTypeNames(instruction, child)
                 }
             }
     }

lib/src/main/java/graphql/nadel/engine/transform/hydration/NadelHydrationTransform.kt

@@ -336,7 +336,6 @@ internal class NadelHydrationTransform(
 
         val backingQueries = NadelHydrationFieldsBuilder.makeBackingQueries(
             executionContext = executionContext,
-            service = state.virtualFieldService,
             instruction = instruction,
             aliasHelper = state.aliasHelper,
             virtualField = virtualField,

test/src/test/kotlin/graphql/nadel/tests/next/fixtures/hydration/HydrationRemainingArgumentsTest.kt

@@ -173,7 +173,6 @@ class HydrationRemainingArgumentsTest : NadelIntegrationTest(
 ) {
     override fun makeExecutionHints(): NadelExecutionHints.Builder {
         return super.makeExecutionHints()
-            .virtualTypeSupport { true }
             .shortCircuitEmptyQuery { true }
     }
 }

test/src/test/kotlin/graphql/nadel/tests/next/fixtures/hydration/statics/StaticHydrationAndPolymorphicHydrationTest.kt

@@ -262,7 +262,6 @@ class StaticHydrationAndPolymorphicHydrationTest : NadelIntegrationTest(
 ) {
     override fun makeExecutionHints(): NadelExecutionHints.Builder {
         return super.makeExecutionHints()
-            .virtualTypeSupport { true }
             .shortCircuitEmptyQuery { true }
     }
 

test/src/test/kotlin/graphql/nadel/tests/next/fixtures/hydration/statics/StaticHydrationNestedErrorTest.kt

@@ -210,7 +210,6 @@ class StaticHydrationNestedErrorTest : NadelIntegrationTest(
 ) {
     override fun makeExecutionHints(): NadelExecutionHints.Builder {
         return super.makeExecutionHints()
-            .virtualTypeSupport { true }
             .shortCircuitEmptyQuery { true }
     }
 

test/src/test/kotlin/graphql/nadel/tests/next/fixtures/hydration/statics/StaticHydrationOverlappingHydrationTest.kt

@@ -257,7 +257,6 @@ class StaticHydrationOverlappingHydrationTest : NadelIntegrationTest(
 ) {
     override fun makeExecutionHints(): NadelExecutionHints.Builder {
         return super.makeExecutionHints()
-            .virtualTypeSupport { true }
             .shortCircuitEmptyQuery { true }
     }
 

test/src/test/kotlin/graphql/nadel/tests/next/fixtures/hydration/statics/StaticHydrationScalarFieldTest.kt

@@ -67,7 +67,6 @@ class StaticHydrationScalarFieldTest : NadelIntegrationTest(
 ) {
     override fun makeExecutionHints(): NadelExecutionHints.Builder {
         return super.makeExecutionHints()
-            .virtualTypeSupport { true }
             .shortCircuitEmptyQuery { true }
     }
 }

test/src/test/kotlin/graphql/nadel/tests/next/fixtures/hydration/statics/StaticHydrationTest.kt

@@ -199,7 +199,6 @@ class StaticHydrationTest : NadelIntegrationTest(
 ) {
     override fun makeExecutionHints(): NadelExecutionHints.Builder {
         return super.makeExecutionHints()
-            .virtualTypeSupport { true }
             .shortCircuitEmptyQuery { true }
     }
 }