Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cognito-identitypool): cleanup the alpha module after it has entered GA #33949

Merged
merged 2 commits into from
Mar 27, 2025

Conversation

Leo10Gama
Copy link
Member

Reason for this change

The cognito-identitypool module was recently stabilized to GA in PR #33905. As such, we have no need for the alpha module any more.

Description of changes

rm -rf aws-cdk/packages/@aws-cdk/aws-cognito-identitypool-alpha

Description of how you validated changes

yarn install && npx lerna run build --skip-nx-cache run successfully.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Sorry, something went wrong.

@github-actions github-actions bot added the p2 label Mar 27, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team March 27, 2025 18:59
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Mar 27, 2025
Copy link

codecov bot commented Mar 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.38%. Comparing base (519f359) to head (669f9bd).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #33949   +/-   ##
=======================================
  Coverage   82.38%   82.38%           
=======================================
  Files         120      120           
  Lines        6955     6955           
  Branches     1173     1173           
=======================================
  Hits         5730     5730           
  Misses       1120     1120           
  Partials      105      105           
Flag Coverage Δ
suite.unit 82.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk ∅ <ø> (∅)
packages/aws-cdk-lib/core 82.38% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 669f9bd
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Mar 27, 2025
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we might need also to change reference in these path to the stable module related to analytics and enum updater

  1. cdk-enums.json
  2. unmatched-enums.json
  3. classes.ts
  4. module-enumlikes.json

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the classes.ts, the header mentions not to edit the file manually, since an automated GitHub workflow maintains it. The enum JSON files are similar, but those ones are linked to a script that's still manual, but again is maintained by automation. So I think it should be fine to leave these untouched for now.

Copy link
Contributor

mergify bot commented Mar 27, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit dc1d9b0 into aws:main Mar 27, 2025
32 checks passed
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 27, 2025
@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Mar 27, 2025
@Leo10Gama Leo10Gama deleted the idp-cleanup branch March 27, 2025 21:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants