-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(cognito-identitypool): cleanup the alpha module after it has entered GA #33949
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
8 changes: 0 additions & 8 deletions
8
packages/@aws-cdk/aws-cognito-identitypool-alpha/.eslintrc.js
This file was deleted.
Oops, something went wrong.
25 changes: 0 additions & 25 deletions
25
packages/@aws-cdk/aws-cognito-identitypool-alpha/.gitignore
This file was deleted.
Oops, something went wrong.
29 changes: 0 additions & 29 deletions
29
packages/@aws-cdk/aws-cognito-identitypool-alpha/.npmignore
This file was deleted.
Oops, something went wrong.
201 changes: 0 additions & 201 deletions
201
packages/@aws-cdk/aws-cognito-identitypool-alpha/LICENSE
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we might need also to change reference in these path to the stable module related to
analytics and enum updater
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the
classes.ts
, the header mentions not to edit the file manually, since an automated GitHub workflow maintains it. The enum JSON files are similar, but those ones are linked to a script that's still manual, but again is maintained by automation. So I think it should be fine to leave these untouched for now.