Skip to content

Conversation

@gmarciani
Copy link
Contributor

Description of changes

Restore locking mechanism to update IMEX nodes config.
We removed it in aws/aws-parallelcluster-cookbook#3029 as we considered it overkilling after moving to local config files. However, having the locking mechanism prevents impacts on IMEX when concurrent jobs are submitted.

Tests

OGNOING test_gb200

References

  • Link to impacted open issues.
  • Link to related PRs in other packages (i.e. cookbook, node).
  • Link to documentation useful to understand the changes.

Checklist

  • Make sure you are pointing to the right branch.
  • If you're creating a patch for a branch other than develop add the branch name as prefix in the PR title (e.g. [release-3.6]).
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@gmarciani gmarciani requested review from a team as code owners September 22, 2025 13:54
@gmarciani gmarciani added skip-changelog-update Disables the check that enforces changelog updates in PRs 3.x Test labels Sep 22, 2025
Even if now the config file is local and we assume exclusive job allocation,
having the locking mechanism prevents impacts on IMEX when concurrent jobs are submitted.
@gmarciani gmarciani force-pushed the wip/mgiacomo/3140/gb200-prolog-0922-1 branch from 3cc06dd to b6c3cb0 Compare September 22, 2025 13:57
@himani2411 himani2411 changed the title [BB200] Restore locking mechanism to update IMEX nodes config. [GB200] Restore locking mechanism to update IMEX nodes config. Sep 22, 2025
@gmarciani
Copy link
Contributor Author

Cancel this PR as we just decided to enforce exclusive job execution by exiting immediately from the prolog if job is not exclusive. In that scenario we do not need any file locking

@gmarciani gmarciani closed this Sep 22, 2025
@gmarciani
Copy link
Contributor Author

Closed in favor of #7019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.x skip-changelog-update Disables the check that enforces changelog updates in PRs Test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants