Add aio/aiohttp.py module #658

TingDaoK · 2025-06-11T22:16:53Z

Issue #, if available:

add aio/aiohttp module, that provides async interface for HTTP functions.

Description of changes:

Connection Classes

AIOHttpClientConnectionUnified
- Base class for both HTTP/1.1 and HTTP/2 connections
- Provides common connection management methods
- Supports asynchronous connection establishment and closure
AIOHttpClientConnection
- HTTP/1.1 specific implementation
- Created via AIOHttpClientConnection.new() async class method
AIOHttp2ClientConnection
- HTTP/2 specific implementation
- Supports HTTP/2 settings configuration
- Created via AIOHttp2ClientConnection.new() async class method
- Supports callbacks for remote settings changes

Stream Classes

AIOHttpClientStreamUnified
- Base class for HTTP streams
- Handles asynchronous request/response exchanges
- Provides methods for retrieving response status, headers, and body chunks
AIOHttpClientStream
- HTTP/1.1 specific stream implementation
AIOHttp2ClientStream
- HTTP/2 specific stream implementation
- Supports incremental body sending via async generators

TODO:

Support incremental body sending via async generators for HTTP/1.1, which will be transfer encoding binding.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

test/test_http_asyncio.py

awscrt/http_asyncio.py

JordonPhillips · 2025-06-17T13:42:15Z

awscrt/http_asyncio.py

+    async def write_data_async(self,
+                               data_stream: Union[InputStream, Any],
+                               end_stream: bool = False) -> None:
+        """Write data to the stream asynchronously.
+
+        Args:
+            data_stream (Union[InputStream, Any]): Data to write.
+            end_stream (bool): Whether this is the last data to write.
+
+        Returns:
+            None: When the write completes.
+        """
+        future = self.write_data(data_stream, end_stream)
+        await asyncio.wrap_future(future)


This is an async method, but it doesn't look like I can actually pass an async data stream in. I would expect this to be able to take an AsyncIterator[bytes] as a data stream. I would also expect the http/1.1 stream to have this method.

Currently a major problem with the using bidirectional streaming in async is that we have to wrap async iterators and treat them like a sync data stream. We can make that work, but it works poorly because the only way to get the CRT to call read later is to throw a particular IO error that gets retried. That retry is immediate though, so you can end up in a situation where the CRT is running a hot loop on the read method as it waits for data to become available in the background.

To solve this, we really need the CRT to read async. Ideally by taking an AsyncIterator, but there might be other ways with Futures to make this an easier transition.

Thank you!

Currently a major problem with the using bidirectional streaming in async is that we have to wrap async iterators and treat them like a sync data stream. We can make that work, but it works poorly because the only way to get the CRT to call read later is to throw a particular IO error that gets retried. That retry is immediate though, so you can end up in a situation where the CRT is running a hot loop on the read method as it waits for data to become available in the background.

I'll look into taking AsyncIterator[bytes].

But I think the major problem here has been resolved by this interface already. I updated the smithy-pyhton here to use this new interface.
Instead of expecting the InputStream to throw the particular IO error, just keep providing the data when it's available. And I tested with the sample, the CPU usage has been dropped from 30% to lower than 10%. Since this API will not just loop to read from the input stream, it wait until more input stream to be provided.

…version Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>

JordonPhillips · 2025-06-19T13:35:16Z

awscrt/aio/aiohttp.py

+    async def _set_request_body_generator(self, body_iterator: AsyncIterator[bytes]):
+        try:
+            async for chunk in body_iterator:
+                await self._write_data(io.BytesIO(chunk), False)


Is there a way to do this without wrapping this in a bytesio? I'm concerned about potential extra copies. It shouldn't happen so long as you do no mutations since it starts by just holding a reference. But I'm not sure what apis are being called.

It should already avoid the extra copy, it will be wrapped by our input stream interface use readinto.
https://github.com/awslabs/aws-crt-python/blob/main/awscrt/io.py#L689-L727

awscrt/aio/aiohttp.py

JordonPhillips · 2025-06-19T13:48:29Z

awscrt/aio/aiohttp.py

+    async def _set_request_body_generator(self, body_iterator: AsyncIterator[bytes]):
+        ...


Is HTTP1.1 not able to share the implementation?

HTTP/1.1 transfer encoding may need to add trailer headers and chunk extensions. So the API may need to be a bit different. Maybe let the iterator to yield a chunkinfo struct that can pass extra info like trailer instead of simple bytes.

Or we can leave trailer header as unsupported for now.

Anyhow I'd want to leave the http/1.1 implementation for a quick follow up PR if we want it.

DmitriyMusatkin · 2025-06-23T21:10:57Z

awscrt/aio/aiohttp.py

+                  bootstrap: Optional[ClientBootstrap] = None,
+                  socket_options: Optional[SocketOptions] = None,
+                  tls_connection_options: Optional[TlsConnectionOptions] = None,
+                  proxy_options: Optional['HttpProxyOptions'] = None) -> "AIOHttpClientConnectionUnified":


why does HttpProxyOptions need to be forward declared?

DmitriyMusatkin · 2025-06-23T21:26:41Z

awscrt/aio/aiohttp.py

+                future.set_result(None)
+
+        _awscrt.http2_client_stream_write_data(self, body_stream, end_stream, on_write_complete)
+        await asyncio.wrap_future(future)


why do we want to use concurrent Future here and then wrap it into asyncio one? why not use async io one from start?

Since the concurrent future is thread safe, but the asyncio one is not.

If we just get asyncio future, we will need to invoke self._loop.call_soon_threadsafe() to set the future. Either way, it's a bit awkward.

But, yeah, I did use the asyncio future directly for some other places, I guess it would be nice to keep it consistent.

TingDaoK · 2025-06-25T18:33:05Z

just out of curiosity, why aiohttp instead of httpx?

I don't get what is the question here, I assume you confused this with the aiohttp project.
We are not depend on them, the awscrt.aio.aiohttp module is an async wrapper for the awscrt.http.
The name of the module is unfortunately confusing, but like our regular http module just named http.py, I don't think it will be a big concern to name our async io http module as aio/aiohttp.py.

nateprewitt · 2025-06-30T20:54:39Z

awscrt/__init__.py

@@ -7,6 +7,7 @@
    'auth',
    'crypto',
    'http',
+    'aio.aiohttp',


nit; aiohttp is an existing library that's already widely used. Would it make more sense for this to just be aio.http since we already have that precedent for the existing http module?

nateprewitt · 2025-06-30T21:24:28Z

awscrt/aio/aiohttp.py

+class AIOHttpClientConnection(AIOHttpClientConnectionUnified):
+    """
+    An async HTTP/1.1 only client connection.
+
+    Use `AIOHttpClientConnection.new()` to establish a new connection.
+    """


What is the intended vision for this connection type? http/1.1 is inherently stateful and we can't multiplex that same way that h2 does. The request() method is also not async, so I'm curious what value this provides in its current state.

Is the idea that you take the stream and then write to it periodically until we get a signal the input is exhausted, then read?

AIOHttpClientConnection is designed to be HTTP/1.1 only. the protocol doesn't support multiplex, but we do some sort support it. The next request/response will just be waiting in the list to be sent after the previous request/response finishes.

The request() method is also not async

There is no async process in the request() method, it will start the request under the hood, and the stream interface will be handle the response async.

awscrt/aio/aiohttp.py

awscrt/http.py

TingDaoK added 14 commits May 27, 2025 13:54

WIP

cdf7bae

next

c433ede

WIP

143b9e9

it works with smithy take2

e87e26e

clean up

e46471c

fix test

6c802b1

clean up

b8af499

couple fixes

5e8eb43

Merge branch 'main' into asyncio-take4

91fbf9c

rename and move the method to be more logically ordered

ad2520b

fix python38

d9c90a5

python 3.8 has been removed by github

7e2dfeb

incase of the future cancelled, just return

584b2f9

edit the comments

e2bbb98

TingDaoK mentioned this pull request Jun 12, 2025

Async CRT smithy-lang/smithy-python#514

Draft

TingDaoK changed the title ~~Asyncio~~ Add http_asyncio Jun 12, 2025

show me the path

7d27da3

github-advanced-security bot found potential problems Jun 16, 2025

View reviewed changes

test/test_http_asyncio.py Fixed Show fixed Hide fixed

JordonPhillips reviewed Jun 17, 2025

View reviewed changes

TingDaoK and others added 11 commits June 17, 2025 14:05

more python style ood

16f67d6

Potential fix for code scanning alert no. 9: Use of insecure SSL/TLS …

54f3e8e

…version Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>

couple more fix

3f48ddd

Merge branch 'main' into asyncio-take4

d851cac

remove unneeded

7584894

I'll fix test later

955d176

use the loop

c95841b

demo for testing

4886a3b

unified interface as the base

76f0e33

fix tests and doc

0fe5d76

naming update

f18b979

TingDaoK added 6 commits June 18, 2025 10:22

typo...

324ec18

hmmm

fdbef55

why???

d3e3ba4

renaming the module and class

c48d68f

update the path

c3a442d

Merge branch 'main' into asyncio-take4

e50a501

TingDaoK marked this pull request as ready for review June 18, 2025 21:26

JordonPhillips reviewed Jun 19, 2025

View reviewed changes

TingDaoK added 2 commits June 19, 2025 09:43

address comments

33914ba

remove the demo

5bced4a

TingDaoK requested a review from JordonPhillips June 20, 2025 17:02

JordonPhillips approved these changes Jun 23, 2025

View reviewed changes

TingDaoK added 2 commits June 23, 2025 10:02

Merge branch 'main' into asyncio-take4

ac7782a

trivial

0ab3899

TingDaoK changed the title ~~Add http_asyncio~~ Add aio/aiohttp.oy module Jun 23, 2025

TingDaoK changed the title ~~Add aio/aiohttp.oy module~~ Add aio/aiohttp.py module Jun 23, 2025

DmitriyMusatkin approved these changes Jun 23, 2025

View reviewed changes

TingDaoK added 3 commits June 23, 2025 16:04

remove unneeded forward declaration

7fdc182

keyword required

eff3d57

use wrap_future for consistence

44e2640

TingDaoK mentioned this pull request Jun 24, 2025

Use anyio to support an idiomatic async interface #558

Closed

1 task

This comment was marked as off-topic.

Sign in to view

nateprewitt reviewed Jul 2, 2025

View reviewed changes

		async def _set_request_body_generator(self, body_iterator: AsyncIterator[bytes]):
		...

Add aio/aiohttp.py module #658

Are you sure you want to change the base?

Add aio/aiohttp.py module #658

Conversation

TingDaoK commented Jun 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Connection Classes

Stream Classes

TODO:

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JordonPhillips Jun 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment was marked as off-topic.

TingDaoK commented Jun 25, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

TingDaoK commented Jun 11, 2025 •

edited

Loading

JordonPhillips Jun 19, 2025 •

edited

Loading