-
Notifications
You must be signed in to change notification settings - Fork 46
Add aio/aiohttp.py module #658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
TingDaoK
wants to merge
39
commits into
main
Choose a base branch
from
asyncio-take4
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
cdf7bae
WIP
TingDaoK c433ede
next
TingDaoK 143b9e9
WIP
TingDaoK e87e26e
it works with smithy take2
TingDaoK e46471c
clean up
TingDaoK 6c802b1
fix test
TingDaoK b8af499
clean up
TingDaoK 5e8eb43
couple fixes
TingDaoK 91fbf9c
Merge branch 'main' into asyncio-take4
TingDaoK ad2520b
rename and move the method to be more logically ordered
TingDaoK d9c90a5
fix python38
TingDaoK 7e2dfeb
python 3.8 has been removed by github
TingDaoK 584b2f9
incase of the future cancelled, just return
TingDaoK e2bbb98
edit the comments
TingDaoK 7d27da3
show me the path
TingDaoK 16f67d6
more python style ood
TingDaoK 54f3e8e
Potential fix for code scanning alert no. 9: Use of insecure SSL/TLS …
TingDaoK 3f48ddd
couple more fix
TingDaoK d851cac
Merge branch 'main' into asyncio-take4
TingDaoK 7584894
remove unneeded
TingDaoK 955d176
I'll fix test later
TingDaoK c95841b
use the loop
TingDaoK 4886a3b
demo for testing
TingDaoK 76f0e33
unified interface as the base
TingDaoK 0fe5d76
fix tests and doc
TingDaoK f18b979
naming update
TingDaoK 324ec18
typo...
TingDaoK fdbef55
hmmm
TingDaoK d3e3ba4
why???
TingDaoK c48d68f
renaming the module and class
TingDaoK c3a442d
update the path
TingDaoK e50a501
Merge branch 'main' into asyncio-take4
TingDaoK 33914ba
address comments
TingDaoK 5bced4a
remove the demo
TingDaoK ac7782a
Merge branch 'main' into asyncio-take4
TingDaoK 0ab3899
trivial
TingDaoK 7fdc182
remove unneeded forward declaration
TingDaoK eff3d57
keyword required
TingDaoK 44e2640
use wrap_future for consistence
TingDaoK File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,6 +7,7 @@ | |
| 'auth', | ||
| 'crypto', | ||
| 'http', | ||
| 'aio.aiohttp', | ||
| 'io', | ||
| 'mqtt', | ||
| 'mqtt5', | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit; aiohttp is an existing library that's already widely used. Would it make more sense for this to just be
aio.httpsince we already have that precedent for the existinghttpmodule?