Merged
Conversation
Refactor shell command in gubbins rule to improve readability and error handling.
Member
|
Thanks! If this makes it more portable that's great. gubbins was a bit weird in terms of paths and allowing output to specified folders, but this might have been changed/improved in newer versions |
Member
|
Think the build failure is because of secrets on the branch, let's see |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The log path for the Gubbins rule seems to be a bit buggy due to the use of
pushdandpopd(at least I was having permissions issues related to it). Updated the shell command for the rule to allow for using a non-relative path.