Skip to content

Conversation

@Jannetty
Copy link
Member

@Jannetty Jannetty commented Oct 21, 2025

Estimated time to review: extra small

Description of changes:

  • made criticalVolume not final
  • added setCriticalVolume to PottsCell
  • added two tests to PottsCell using setCriticalVolume (really just one, I just kept the pattern of testing the functions in mocks with and without regions, second test is redundant though)

Brief justification of changes:
We want the critical volume of the stem cells in the fly work to be able to change as a function of the cell's volume immediately following division (different types of division yield locations of very different sizes). In order to do this we need to be able to change the criticalVolume of the cells.

@Jannetty Jannetty self-assigned this Oct 21, 2025
@Jannetty Jannetty added type: feature Improvement or additions to the code base package: potts Related to the potts implementation category: agent Related to the agent subpackages size: xsmall Estimated size of issue or PR is xsmall labels Oct 21, 2025
@Jannetty Jannetty requested review from a team, allison-li-1016, cainja, daniellevahdat, jacob-evarts, jessicasyu, kristaphommatha and pohaoc2 and removed request for a team October 21, 2025 20:24
@Jannetty Jannetty marked this pull request as ready for review October 21, 2025 20:25
@Jannetty Jannetty merged commit ade26b0 into main Dec 1, 2025
6 checks passed
@Jannetty Jannetty deleted the feature/make-critvol-settable branch December 1, 2025 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: agent Related to the agent subpackages package: potts Related to the potts implementation size: xsmall Estimated size of issue or PR is xsmall type: feature Improvement or additions to the code base

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants