Skip to content

Making critical volume settable #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jannetty merged 2 commits into from
Dec 1, 2025
Merged

Making critical volume settable #200

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
306c816
making critical volume settable
Jannetty Oct 21, 2025
d65d90e
Merge branch 'main' into feature/make-critvol-settable
Jannetty Dec 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/arcade/potts/agent/cell/PottsCell.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ public abstract class PottsCell implements Cell {
private final EnumMap<Region, Double> targetRegionSurfaces;

/** Critical volume for cell [voxels]. */
final double criticalVolume;
double criticalVolume;

/** Critical volumes for cell by region [voxels]. */
final EnumMap<Region, Double> criticalRegionVolumes;
Expand Down Expand Up @@ -295,6 +295,15 @@ public double getCriticalVolume() {
return criticalVolume;
}

/**
* Sets the critical volume of the cell.
*
* @param newCriticalVolume the new critical volume
*/
public void setCriticalVolume(double newCriticalVolume) {
criticalVolume = newCriticalVolume;
}

/**
* Gets the critical volume for a region.
*
Expand Down
22 changes: 22 additions & 0 deletions test/arcade/potts/agent/cell/PottsCellTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -652,6 +652,28 @@ public void getCriticalVolume_afterInitializeNoRegion_returnsZero() {
}
}

@Test
public void setCriticalVolume_calledWithRegions_correctlySetsCriticalVolume() {
PottsCell cell = new PottsCellMock(containerWithRegions, locationMock, parametersMock);
assertEquals(cellCriticalVolume, cell.getCriticalVolume());
double newCriticalVolume = randomDoubleBetween(10, 20);
cell.setCriticalVolume(newCriticalVolume);
assertEquals(newCriticalVolume, cell.getCriticalVolume());
cell.setCriticalVolume(cellCriticalVolume);
assertEquals(cellCriticalVolume, cell.getCriticalVolume());
}

@Test
public void setCriticalVolume_calledWithoutRegions_correctlySetsCriticalVolume() {
PottsCell cell = new PottsCellMock(containerWithoutRegions, locationMock, parametersMock);
assertEquals(cellCriticalVolume, cell.getCriticalVolume());
double newCriticalVolume = randomDoubleBetween(10, 20);
cell.setCriticalVolume(newCriticalVolume);
assertEquals(newCriticalVolume, cell.getCriticalVolume());
cell.setCriticalVolume(cellCriticalVolume);
assertEquals(cellCriticalVolume, cell.getCriticalVolume());
}

@Test
public void getCriticalHeight_beforeInitialize_returnsValue() {
assertEquals(cellCriticalHeight, cellWithoutRegions.getCriticalHeight(), EPSILON);
Expand Down
Loading