Force migrate 'alter' on tests#50
Merged
Merged
Conversation
…ore's default: balderdashy/waterline#887
Contributor
|
Seems good to me ✔️ |
Member
Author
|
@tjwebb, if we compare the latest master build (using the merged new default balderdashy/waterline#962) we can see: On sails-postgresql and sails-mysql most tests don't even run because of On the other hand this PR's build brings the results to normality: With only the known/expected errors. Any other concerns or shall we merge this as well? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Force default
migrate: 'alter'so it's independent from waterline core's default: balderdashy/waterline#887Addresses balderdashy/waterline#887