Skip to content

#887: change default migration to 'safe'#962

Merged
tjwebb merged 1 commit into
masterfrom
887-default_safe
Apr 23, 2015
Merged

#887: change default migration to 'safe'#962
tjwebb merged 1 commit into
masterfrom
887-default_safe

Conversation

@dmarcelino
Copy link
Copy Markdown
Member

Fixes #887.

Depends on balderdashy/waterline-adapter-tests#50 or the integration tests will be broken.

@devinivy
Copy link
Copy Markdown
Contributor

✔️ looks good!

@tjwebb
Copy link
Copy Markdown
Contributor

tjwebb commented Apr 23, 2015

The tests are already broken in balderdashy/waterline-adapter-tests#50. Should I merge that anyway?

@dmarcelino
Copy link
Copy Markdown
Member Author

Looks like you've merged already... @tjwebb, the waterline-adapter-tests always fail because of issues in sails-postgresql (balderdashy/waterline-sequel#43), sails-mongo (balderdashy/sails-mongo#260), sails-mysql (balderdashy/waterline-adapter-tests#52) and sails-redis (this one will take more than 1 issue to fix).

The reason for not merging before balderdashy/waterline-adapter-tests#50 is that this is going to break (additional) integration tests on schemaful adapters. So lets merge balderdashy/waterline-adapter-tests#50 so to not destroy everyone's tests :)

@particlebanana
Copy link
Copy Markdown
Contributor

Just for posterity we need to look into sails and see if it relies on the default being alter. We should set it in sails so that it doesn't matter what the default here is but I'm not sure that's being done.

Either way lets be safe in get this in 0.11. Thanks everyone!

@dmarcelino dmarcelino deleted the 887-default_safe branch July 2, 2015 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants