#887: change default migration to 'safe'#962
Conversation
|
✔️ looks good! |
|
The tests are already broken in balderdashy/waterline-adapter-tests#50. Should I merge that anyway? |
|
Looks like you've merged already... @tjwebb, the waterline-adapter-tests always fail because of issues in sails-postgresql (balderdashy/waterline-sequel#43), sails-mongo (balderdashy/sails-mongo#260), sails-mysql (balderdashy/waterline-adapter-tests#52) and sails-redis (this one will take more than 1 issue to fix). The reason for not merging before balderdashy/waterline-adapter-tests#50 is that this is going to break (additional) integration tests on schemaful adapters. So lets merge balderdashy/waterline-adapter-tests#50 so to not destroy everyone's tests :) |
|
Just for posterity we need to look into sails and see if it relies on the default being alter. We should set it in sails so that it doesn't matter what the default here is but I'm not sure that's being done. Either way lets be safe in get this in 0.11. Thanks everyone! |
Fixes #887.
Depends on balderdashy/waterline-adapter-tests#50 or the integration tests will be broken.