Skip to content

Conversation

@meteorcloudy
Copy link
Member

@meteorcloudy meteorcloudy commented Nov 5, 2025

@bazel-io
Copy link
Member

bazel-io commented Nov 5, 2025

Hello @mering, modules you maintain (protoc-gen-validate) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

@meteorcloudy meteorcloudy added presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval skip-url-stability-check Skip the URL stability check for the PR labels Nov 5, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds version 1.2.1.bcr.2 of the protoc-gen-validate module to fix compatibility with Bazel 9. The changes include adding a new module version with updated dependencies and a patch to fix load statements. The presubmit.yml is also updated to test against Bazel 9. The changes are generally good and follow the BCR guidelines. I have a couple of suggestions to improve the maintainability of the MODULE.bazel file by using for loops instead of list comprehensions for side effects, which is the idiomatic way in Starlark.

@meteorcloudy meteorcloudy enabled auto-merge (squash) November 5, 2025 13:32
@bazel-io
Copy link
Member

bazel-io commented Nov 5, 2025

Hello @mering, modules you maintain (envoy_api, protoc-gen-validate) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

@meteorcloudy meteorcloudy changed the title Fix protoc-gen-validate for Bazel 9 Fix protoc-gen-validate and envoy_api for Bazel 9 Nov 5, 2025
@meteorcloudy meteorcloudy changed the title Fix protoc-gen-validate and envoy_api for Bazel 9 Fix grpc, protoc-gen-validate and envoy_api for Bazel 9 Nov 5, 2025
@bazel-io
Copy link
Member

bazel-io commented Nov 5, 2025

Hello @veblush, @pawbhard, @eugeneo, @drfloob, @rishesh007, @markdroth, @yashykt, @apolcyn, @sergiitk, @sreenithi, @stanley-cheung, modules you maintain (grpc) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

mering
mering previously approved these changes Nov 5, 2025
Copy link
Contributor

@mering mering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!

bazel:
- 7.x
- 8.x
- 9.*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity: What is the difference between .x and .*? Should we align on one approach?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

9.* fetches the latest release or release rc. 9.x only fetches the latest official release, which doesn't exist yet.

Comment on lines +20 to +21
- cfg = "host",
+ cfg = "exec",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: I would expect protoc to be used at build time and therefore u sing host instead of exec. Can you elaborate on this change?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The execution platform is not necessarily the host platform when doing remote execution. This change is needed for --incompatible_disable_starlark_host_transitions, also upstreamed at bufbuild/protoc-gen-validate@0ca681b

@bazel-io bazel-io dismissed mering’s stale review November 5, 2025 14:39

Require module maintainers' approval for newly pushed changes.

@bazel-io
Copy link
Member

bazel-io commented Nov 5, 2025

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (c-ares) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

@meteorcloudy meteorcloudy changed the title Fix grpc, protoc-gen-validate and envoy_api for Bazel 9 Fix grpc, protoc-gen-validate and envoy_api, c-ares for Bazel 9 Nov 5, 2025
@meteorcloudy meteorcloudy merged commit fbb475a into bazelbuild:main Nov 5, 2025
70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval skip-url-stability-check Skip the URL stability check for the PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants