-
Notifications
You must be signed in to change notification settings - Fork 645
Fix grpc, protoc-gen-validate and envoy_api, c-ares for Bazel 9 #6422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
meteorcloudy
merged 19 commits into
bazelbuild:main
from
meteorcloudy:protoc-gen-validate-bazel-9
Nov 5, 2025
Merged
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
eac859a
Fix protoc-gen-validate for Bazel 9
meteorcloudy 7b2b04e
Fix abseil-cpp
meteorcloudy b256377
Fix windows build
meteorcloudy 5f6b84e
Fix windows build
meteorcloudy 1934680
Add envoy 0.0.0-20251105-4a2b9a3 and fix for Bazel 9
meteorcloudy b2206bf
Fix presubmit
meteorcloudy ad41c94
Fix presubmit
meteorcloudy ba19982
Update MODULE.bazel
meteorcloudy e363ec5
Fixes
meteorcloudy 2d8a587
Fixes
meteorcloudy c85202c
Add grpc 1.76.0
meteorcloudy baba7bd
Fixes
meteorcloudy fc74b85
Fixes
meteorcloudy 73a7f5c
Fix missing deps for grpc
meteorcloudy d0c73d9
Fix Bazel 7
meteorcloudy 3e3f8ca
fix
meteorcloudy 22c84fe
Bump rules_swift version
meteorcloudy 98fe9de
Fix c-ares for Bazel 9
meteorcloudy e3979c0
Add REPO.bazel for grpc
meteorcloudy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,93 @@ | ||
| module( | ||
| name = "protoc-gen-validate", | ||
| version = "1.2.1.bcr.2", | ||
| compatibility_level = 1, | ||
| repo_name = "com_envoyproxy_protoc_gen_validate", | ||
| bazel_compatibility = ['>=7.2.1'], | ||
| ) | ||
|
|
||
| bazel_dep( | ||
| name = "bazel_skylib", | ||
| version = "1.8.1", | ||
| ) | ||
| bazel_dep( | ||
| name = "gazelle", | ||
| version = "0.46.0", | ||
| repo_name = "bazel_gazelle", | ||
| ) | ||
| bazel_dep( | ||
| name = "protobuf", | ||
| version = "33.0", | ||
| repo_name = "com_google_protobuf", | ||
| ) | ||
| bazel_dep( | ||
| name = "re2", | ||
| version = "2024-07-02.bcr.1", | ||
| repo_name = "com_googlesource_code_re2", | ||
| ) | ||
| bazel_dep( | ||
| name = "rules_cc", | ||
| version = "0.2.13", | ||
| ) | ||
| bazel_dep( | ||
| name = "rules_go", | ||
| version = "0.58.3", | ||
| repo_name = "io_bazel_rules_go", | ||
| ) | ||
| bazel_dep( | ||
| name = "rules_java", | ||
| version = "8.16.1", | ||
| ) | ||
| bazel_dep( | ||
| name = "rules_proto", | ||
| version = "7.1.0", | ||
| ) | ||
| bazel_dep( | ||
| name = "rules_python", | ||
| version = "1.6.0", | ||
| ) | ||
| # -- bazel_dep definitions -- # | ||
|
|
||
| go_sdk = use_extension("@io_bazel_rules_go//go:extensions.bzl", "go_sdk") | ||
| go_sdk.download(version = "1.24.0") | ||
|
|
||
| go_deps = use_extension("@bazel_gazelle//:extensions.bzl", "go_deps") | ||
| go_deps.from_file(go_mod = "//:go.mod") | ||
| use_repo( | ||
| go_deps, | ||
| "com_github_iancoleman_strcase", | ||
| "com_github_lyft_protoc_gen_star_v2", | ||
| "org_golang_google_protobuf", | ||
| "org_golang_x_net", | ||
| ) | ||
|
|
||
| PYTHON_VERSIONS = [ | ||
| "3.9", | ||
| "3.10", | ||
| "3.11", | ||
| "3.12", | ||
| "3.13", | ||
| ] | ||
|
|
||
| python = use_extension("@rules_python//python/extensions:python.bzl", "python") | ||
|
|
||
| [ | ||
| python.toolchain( | ||
| is_default = python_version == PYTHON_VERSIONS[-1], | ||
| python_version = python_version, | ||
| ) | ||
| for python_version in PYTHON_VERSIONS | ||
| ] | ||
|
|
||
| pip = use_extension("@rules_python//python/extensions:pip.bzl", "pip") | ||
|
|
||
| [ | ||
| pip.parse( | ||
| hub_name = "pgv_pip_deps", | ||
| python_version = python_version, | ||
| requirements_lock = "//python:requirements.txt", | ||
| ) | ||
| for python_version in PYTHON_VERSIONS | ||
| ] | ||
meteorcloudy marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| use_repo(pip, "pgv_pip_deps") | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| ../MODULE.bazel |
15 changes: 15 additions & 0 deletions
15
modules/protoc-gen-validate/1.2.1.bcr.2/patches/fix_load.patch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| diff --git a/bazel/protobuf.bzl b/bazel/protobuf.bzl | ||
| index 08d9d56..abf3648 100644 | ||
| --- a/bazel/protobuf.bzl | ||
| +++ b/bazel/protobuf.bzl | ||
| @@ -1,6 +1,8 @@ | ||
| load("@bazel_skylib//rules:common_settings.bzl", "BuildSettingInfo") | ||
| -load("@bazel_tools//tools/jdk:toolchain_utils.bzl", "find_java_runtime_toolchain", "find_java_toolchain") | ||
| -load("@rules_proto//proto:defs.bzl", "ProtoInfo") | ||
| +load("@bazel_tools//tools/jdk:toolchain_utils.bzl", "find_java_toolchain") | ||
| +load("@com_google_protobuf//bazel/common:proto_info.bzl", "ProtoInfo") | ||
| +load("@rules_java//java/common:java_common.bzl", "java_common") | ||
| +load("@rules_java//java/common:java_info.bzl", "JavaInfo") | ||
|
|
||
| # Borrowed from https://github.com/grpc/grpc-java/blob/v1.28.0/java_grpc_library.bzl#L59 | ||
| # "repository" here is for Bazel builds that span multiple WORKSPACES. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| matrix: | ||
| platform: | ||
| - debian11 | ||
| - macos | ||
| - macos_arm64 | ||
| - ubuntu2004 | ||
| - ubuntu2204 | ||
| - ubuntu2404 | ||
| - windows | ||
| bazel: | ||
| - 7.x | ||
| - 8.x | ||
| - 9.* | ||
| tasks: | ||
| verify_targets: | ||
| name: Verify build targets | ||
| platform: ${{ platform }} | ||
| bazel: ${{ bazel }} | ||
| build_flags: | ||
| - '--cxxopt=-std=c++17' | ||
| build_targets: | ||
| - '@protoc-gen-validate//bazel/go:pgv_plugin_go' | ||
| - '@protoc-gen-validate//validate:cc_validate' | ||
| - '@protoc-gen-validate//validate:go_default_library' | ||
| - '@protoc-gen-validate//validate:validate_proto' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| { | ||
| "url": "https://github.com/bufbuild/protoc-gen-validate/archive/refs/tags/v1.2.1.tar.gz", | ||
| "integrity": "sha256-5HGDUnVN8Tk7h5K2MTOKqFYvOQ6BYHg+NlRUvBHZYyg=", | ||
| "strip_prefix": "protoc-gen-validate-1.2.1", | ||
| "overlay": { | ||
| "MODULE.bazel": "sha256-O9SxSo58eNvvlzKA3quqE52x/jUKqS2gNzCjH1kIIGg=" | ||
| }, | ||
| "patches": { | ||
| "fix_load.patch": "sha256-QnIju+GABjHhY8K1DNZjZIX98kwy3rUGjuACUC6T4CY=" | ||
| }, | ||
| "patch_strip": 1 | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -14,7 +14,8 @@ | |
| "1.0.4.bcr.1", | ||
| "1.0.4.bcr.2", | ||
| "1.2.1", | ||
| "1.2.1.bcr.1" | ||
| "1.2.1.bcr.1", | ||
| "1.2.1.bcr.2" | ||
| ], | ||
| "yanked_versions": {} | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.