Improve proc_macro_deps ergonomics, take 3 #3605
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dzbarsky
commented
Sep 9, 2025
| crate_info = dep[rust_common.crate_info] if rust_common.crate_info in dep else None, | ||
| dep_info = dep[rust_common.dep_info] if rust_common.crate_info in dep else None, | ||
| crate_info = dep[CrateInfo] if CrateInfo in dep else None, | ||
| dep_info = dep[DepInfo] if DepInfo in dep else None, |
There was a problem hiding this comment.
cleaned up provider references while I was here and discovered dep_info was cheking for the CrateInfo provider but using DepInfo one :)
dzbarsky
force-pushed
the
zbarsky/proc-macros-3
branch
from
5a6ee86 to
662ca6d
Compare
dzbarsky
force-pushed
the
zbarsky/proc-macros-3
branch
from
662ca6d to
bed15ce
Compare
This was referenced Sep 9, 2025
|
I love this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can stop forcing users to sort their deps into
depsandproc_macro_deps; instead all deps are supplied todepsin the public macros and the rules sort it out.Best reviewed commit by commit.
I kept the
proc_macro_depsattribute named the same just in case, but it would be nice to rename toexec_configured_depsat some point to reflect reality.Fixes #2893