Repository navigation
ci: narrow workflow triggers and skip Markdown-only changes - #123
Merged
Merged
Conversation
PG Upgrade, oc-runner commands, Test Crunchy and Test Image Import now gate on job-level diff-triggers, so docs-only changes skip them while their checks still report. PG Upgrade matches only the oc-runner login it depends on. cert-expiry paths and the Route TLS filter ignore *.md.
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Three new gates inspect only the final commit of pushes and can skip tests for earlier code changes.
3 open findings
What changed in this PR
This PR reduces unnecessary CI work by gating tests on relevant file changes and excluding Markdown-only changes.
Changes:
- Adds path-filter jobs for PG Upgrade, oc-runner, Crunchy, and Image Import tests.
- Excludes Markdown from Route TLS and certificate-expiry triggers.
- Documents workflow-trigger requirements.
| File | Description |
|---|---|
| AGENTS.md | Documents trigger scoping and check-reporting requirements. |
| .github/workflows/pr-open.yml | Gates selected tests and excludes Markdown. |
| .github/workflows/pg-upgrade.yml | Replaces workflow-level filtering with job gates. |
| .github/workflows/oc-runner-commands.yml | Adds path-based gates for both test jobs. |
| .github/workflows/cert-expiry-tests.yml | Excludes Markdown from workflow triggers. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docs-only #122 ran the full PG Upgrade container matrix because
pg-upgrade.ymlmatched all ofoc-runner/**. This narrows that trigger and fixes the other workflows with the same problem.Changes by workflow
pathsfilter is gone, so the workflow always runs and its checks always report. A newPG Upgrade (changes)job runsbcgov/actions/diff-triggers(SHA-pinned v0.8.0, using the same merge-base step aspr-open.yml).versionsandunithaveif:gates, andcontainersskips along with them. Triggers:pg-upgrade/,.github/tests/pg-upgrade/, the workflow itself, andoc-runner/action.ymlplusoc-runner/scripts/login.sh, the only oc-runner files pg-upgrade uses (login).*.mdis excluded.oc-runner (changes)job gates both test jobs onoc-runner/,.github/tests/oc-runner/and the workflow itself, excluding*.md.Path filtersjob (diff-triggersfilters) gatesTest Crunchy(crunchy, route-tls and image-import code and tests) andTest Image Import(image-import plus the oc-runner action and scripts). Both used to run on every PR.Route TLS path filternow excludes*.md. Actionlint and Test Deployer are unchanged; the deployer already uses its owntriggers.pathsfilter and adds!**/*.md.No jobs were renamed. Skipped jobs show as skipped, not missing. Note that the
mainruleset currently requires no status checks, and the repo has noworkflow-resultsgate job. No version changes.