Skip to content

Sprite picking docs fix #19016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 5, 2025
Merged

Sprite picking docs fix #19016

merged 2 commits into from
May 5, 2025

Conversation

akimakinai
Copy link
Contributor

@akimakinai akimakinai commented May 1, 2025 •
edited
Loading

Objective

  • Docs in sprite picking plugin / example contain outdated information.

References:

Solution

  • Fix the docs.

Carter0
Carter0 approved these changes May 1, 2025
View reviewed changes
Copy link
Contributor

@Carter0 Carter0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Carter0 Carter0 added C-Docs An addition or correction to our documentation S-Needs-Review Needs reviewer attention (from anyone!) to move forward D-Trivial Nice and easy! A great choice to get started with Bevy labels May 1, 2025
@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels May 5, 2025
@mockersf mockersf added this pull request to the merge queue May 5, 2025
Merged via the queue into bevyengine:main with commit 0f6d532 May 5, 2025
41 checks passed
@akimakinai akimakinai deleted the picking_comment branch May 5, 2025 18:27
andrewzhurov pushed a commit to andrewzhurov/bevy that referenced this pull request May 17, 2025
@akimakinai @andrewzhurov
Sprite picking docs fix (bevyengine#19016)
f8dd8c3 
# Objective

- Docs in sprite picking plugin / example contain outdated information.

References:
- Sprite picking now always require `Picking` - bevyengine#17842
- Transparency pass-through added - bevyengine#16388

## Solution

- Fix the docs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mockersf mockersf mockersf approved these changes

@Carter0 Carter0 Carter0 approved these changes

@mnmaita mnmaita mnmaita approved these changes

Assignees
No one assigned
Labels
C-Docs An addition or correction to our documentation D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@akimakinai @mockersf @Carter0 @mnmaita @alice-i-cecile