-
-
Notifications
You must be signed in to change notification settings - Fork 4k
Add bevy_fbx, an FBX loader based on ufbx #19534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The generated |
It looks like your PR has been selected for a highlight in the next release blog post, but you didn't provide a release note. Please review the instructions for writing release notes, then expand or revise the content in the release notes directory to showcase your changes. |
8324b93
to
8bae92e
Compare
as it uses a native dependency, I don't think it should be part of the default features |
Agreed with @mockersf. FBX support would be very nice, but C++ dependencies add a lot of pain to the out-of-the-box experience in many cases, so let's make it opt-in. |
The generated |
ufbx is a self-contained FBX loader made up of just two files— |
You added a new feature but didn't add a description for it. Please update the root Cargo.toml file. |
11c909c
to
f39dd2d
Compare
I know it's still WIP, but it would be way easier to review if the main load() function was split into multiple functions. A bit like how bevy_gltf has load_materials, load_image, load_node, etc. Also, once the PR is ready to merge I think it should only have one .fbx file in the asset folder. It's a good feature to have but we need to keep the size of the repo in check. |
I will refactor the main load() function following |
You added a new feature but didn't add a description for it. Please update the root Cargo.toml file. |
Objective
ufbx
Solution
bevy_fbx
, an FBX loader based on ufbx.Testing
load_fbx
,asset_loading
.Showcase
TODO
While a showcase should aim to be brief and digestible, you can use a toggleable section to save space on longer showcases:
Click to view showcase