Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added some missing dependencies for Linux #2267

Closed
wants to merge 2 commits into from
Closed

Conversation

TCROC
Copy link

@TCROC TCROC commented May 28, 2021

@jakobhellermann and I found that bevy on linux was missing some dependencies here: orhun/kmon#2

Here is the part of the discussion that he found it: https://discord.com/channels/691052431525675048/789987800014651412/847858021907300352

And here is the entire discussion: https://discord.com/channels/691052431525675048/789987800014651412/847854179312468009

@NathanSWard NathanSWard added O-Linux Specific to the Linux desktop operating system dependencies C-Docs An addition or correction to our documentation and removed dependencies labels May 28, 2021
@cart
Copy link
Member

cart commented May 29, 2021

Hmm these dependencies look really internal / nasty. Are we sure there isn't some "parent package" that should be installed instead?

@TCROC
Copy link
Author

TCROC commented May 31, 2021

I'm not sure. All I know is I couldn't compile or run the bevy program without those dependencies and I already had those ones that are currently listed in the Linux dependencies installed.

@TCROC
Copy link
Author

TCROC commented May 31, 2021

Is there a way we can query the package database for a parent package containing this dependencies?

@TCROC
Copy link
Author

TCROC commented May 31, 2021

@jakobhellermann Found a parent package that is much cleaner. I updated the PR accordingly: libxcb-xfixes0-dev

https://discord.com/channels/691052431525675048/789987800014651412/848988258721464401

@mockersf
Copy link
Member

A little googling seems to indicate that libxcb (X c-binding) goal is to replace Xlib, that we're already adding as a dependency as libX11.

I don't know which is the way to go, but I don't think we should have both

@TCROC
Copy link
Author

TCROC commented Jun 1, 2021

@mockersf How far away are they from that goal? Currently it doesn't work and leaves things broken for Ubuntu users such as myself. Once they reach the goal, then I agree that we should remove the package.

@mockersf
Copy link
Member

mockersf commented Jun 1, 2021

@mockersf How far away are they from that goal?

No idea... the project started 20 yers ago, so another 50 maybe?

Currently it doesn't work and leaves things broken for Ubuntu users such as myself.

I don't think it is... Our CI is using ubuntu and it works. The packages installed by default are listed here and we install a few additional:

run: sudo apt-get update; sudo apt-get install --no-install-recommends libasound2-dev libudev-dev

Could you check on a clean ubuntu?

@TCROC
Copy link
Author

TCROC commented Jun 1, 2021

@mockersf I'll spin up a VM when I get a spare moment and see what happens.

@mockersf mockersf added the S-Pre-Relicense This PR was made before Bevy added the Apache license. Cannot be merged or used for other work label Jul 16, 2021
@alice-i-cecile
Copy link
Member

I'm going to close this out for now; the CI argument is compelling to me. If you can reproduce it feel free to open it back up or make a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-Docs An addition or correction to our documentation O-Linux Specific to the Linux desktop operating system S-Pre-Relicense This PR was made before Bevy added the Apache license. Cannot be merged or used for other work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants