Skip to content

Conversation

@FindlayRoyds
Copy link

Objective

The default value for DepthOfFieldMode is Gaussian, but the default implementation of DepthOfField uses Bokeh.

Old version:

pub enum DepthOfFieldMode {
    /// ...
    Bokeh,

    /// ...
    /// This is the default.
    /// ...
    #[default]
    Gaussian,
}

impl Default for DepthOfField {
    fn default() -> Self {
        // ...
        Self {
            // ...
            mode: DepthOfFieldMode::Bokeh,
        }
    }
}

Solution

This PR updates DepthOfField to use the default value of DepthOfFieldMode.

Testing

The depth of field example compiles and runs. I adjusted it to use the default mode of DepthOfField and it correctly uses Gaussian now.

@github-actions
Copy link
Contributor

Welcome, new contributor!

Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨

@alice-i-cecile alice-i-cecile added C-Bug An unexpected or incorrect behavior A-Rendering Drawing game state to the screen S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jan 28, 2026
@alice-i-cecile alice-i-cecile added the D-Straightforward Simple bug fixes and API improvements, docs, test and examples label Jan 28, 2026
@github-project-automation github-project-automation bot moved this to Needs SME Triage in Rendering (2026 Proposal) Jan 28, 2026
@Zeophlite Zeophlite added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jan 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

Status: No status
Status: Needs SME Triage

Development

Successfully merging this pull request may close these issues.

5 participants