Skip to content

Conversation

@Lampan-git
Copy link
Contributor

Objective

  • I use a compute shader to update the transforms and write them to MeshInput directly for some entities and doesn't readback to the CPU. This has the unfortunate side-effect of making the main world transform positions always being (0,0) and then being frustum culled on the CPU side. There is no way to disable CPU culling per entity, hence this PR.

Solution

  • Use the same Has<NoCpuCulling> for visible_aabb_query as view_query

Testing

I checked in RenderDoc for VkDrawIndexedIndirectCommand's instanceCount, which results in the same number as without NoCpuCulling, and lower number than with NoFrustumCulling. It also works when looking away from the center.

Note that this is my first real contribution and I have no real rendering experience.

@kristoff3r kristoff3r added A-Rendering Drawing game state to the screen S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Feb 1, 2026
@github-project-automation github-project-automation bot moved this to Needs SME Triage in Rendering (2026 Proposal) Feb 1, 2026
@kristoff3r kristoff3r added the D-Straightforward Simple bug fixes and API improvements, docs, test and examples label Feb 1, 2026
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add docs to NoCpuCulling to document this behavior?

@alice-i-cecile alice-i-cecile added C-Feature A new feature, making something new possible S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Feb 2, 2026
Copy link
Contributor

@IceSentry IceSentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with the comment from alice to add docs but otherwise LGTM

@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged labels Feb 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Rendering Drawing game state to the screen C-Feature A new feature, making something new possible D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

Status: No status
Status: Needs SME Triage

Development

Successfully merging this pull request may close these issues.

4 participants